Page MenuHomeFreeBSD
Differential D7103

hyperv/vmbus: Move new channel scan notification to device register
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jul 5 2016, 6:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 5:40 AM
Unknown Object (File)
Tue, Mar 11, 10:17 AM
Unknown Object (File)
Jan 29 2025, 1:09 AM
Unknown Object (File)
Jan 16 2025, 7:21 PM
Unknown Object (File)
Jan 10 2025, 12:08 PM
Unknown Object (File)
Jan 6 2025, 12:10 AM
Unknown Object (File)
Oct 4 2024, 3:35 AM
Unknown Object (File)
Oct 3 2024, 12:54 PM
View All 57 Files
Subscribers
None

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
Commits
rS302810: hyperv/vmbus: Move new channel scan notification to device register
Summary

And nuke now unnecessary function indirection.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 18135.Jul 5 2016, 6:33 AM
sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Move new channel scan notification to device register.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
Closed by commit rS302810: hyperv/vmbus: Move new channel scan notification to device register (authored by sephe). · Explain WhyJul 14 2016, 6:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
vmbus/
30 lines
3 lines

Diff 18406

View Options

head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c

Show All 26 Lines
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" @(#)bsearch.3 8.3 (Berkeley) 4/19/94 .\" @(#)bsearch.3 8.3 (Berkeley) 4/19/94
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd May 15, 2019 .Dd July 17, 2019
.Dt BSEARCH 3 .Dt BSEARCH 3
.Os .Os
.Sh NAME .Sh NAME
.Nm bsearch .Nm bsearch
.Nd binary search of a sorted table .Nd binary search of a sorted table
.Sh LIBRARY .Sh LIBRARY
.Lb libc .Lb libc
.Sh SYNOPSIS .Sh SYNOPSIS
▲ Show 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
.Bd -literal .Bd -literal
#include <assert.h> #include <assert.h>
#include <stdint.h> #include <stdint.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
struct person { struct person {
char name[5]; const char *name;
hrsUnsubmitted
Done
Inline Actions

Do not use a hard-coded array length here. (const char *) should be enough.

hrs: Do not use a hard-coded array length here. (const char *) should be enough.
int age; int age;
}; };
int static int
compare(const void *key, const void *array_member) compare(const void *a, const void *b)
hrsUnsubmitted
Done
Inline Actions
  • As explained in my other comment, two arguments are supposed to be pointers for an object (the key object and an array member object), not a key "value" and an object.
  • Use simple variable names such as "a" and "b", which are commonly used in this kind of examples.
hrs: - As explained in my other comment, two arguments are supposed to be pointers for an object…
{ {
int age = (intptr_t) key; const int *age;
struct person person = *(struct person *) array_member; const struct person *person;
hrsUnsubmitted
Done
Inline Actions

Two problems:

  • Use a pointer instead of copying the array_member. This causes unnecessary overhead.
  • "const" must be used because array_member is (const void *).

Thus (const struct person *) is better.

hrs: Two problems: - Use a pointer instead of copying the array_member. This causes unnecessary…
return (age - person.age); age = a;
person = b;
return (*age - person->age);
} }
hrsUnsubmitted
Done
Inline Actions

Use main(void) if you do not use the command line arguments.

hrs: Use main(void) if you do not use the command line arguments.
int int
main() main(void)
{ {
hrsUnsubmitted
Not Done
Inline Actions

I think it is better to move the definition of "friends" to just after the declaration of struct person. It is easier for the readers to understand an example which has data structure and contents on a close location.

hrs: I think it is better to move the definition of "friends" to just after the declaration of…
struct person *friend; struct person *friend;
hrsUnsubmitted
Done
Inline Actions

Do not use a hard-coded array length. [] works.

hrs: Do not use a hard-coded array length. [] works.
int age;
/* Sorted array */ /* Sorted array */
struct person friends[6] = { const struct person friends[] = {
{ "paul", 22 }, { "paul", 22 },
{ "anne", 25 }, { "anne", 25 },
{ "fred", 25 }, { "fred", 25 },
{ "mary", 27 }, { "mary", 27 },
{ "mark", 35 }, { "mark", 35 },
{ "bill", 50 } { "bill", 50 }
hrsUnsubmitted
Done
Inline Actions

Do not use sizeof(type) wherever possible. The following is better:

len = sizeof(friends) / sizeof(friends[0]);
hrs: Do not use sizeof(type) wherever possible. The following is better: ``` len = sizeof(friends)…
}; };
const size_t len = sizeof(friends) / sizeof(friends[0]);
hrsUnsubmitted
Done
Inline Actions
  • Create a key object for "22" and pass it as the first argument without casting.
  • Use sizeof(friends[0]) or sizeof("key object name") instead of sizeof(struct person).
hrs: - Create a key object for "22" and pass it as the first argument without casting. - Use sizeof…
size_t array_size = sizeof(friends) / sizeof(struct person); age = 22;
hrsUnsubmitted
Not Done
Inline Actions

Why "\e" is used here? I guess "\n" is intended.

hrs: Why "\e" is used here? I guess "\n" is intended.
jillesUnsubmitted
Not Done
Inline Actions

The \e is required due to mdoc markup. Writing just \n does not render properly.

jilles: The `\e` is required due to mdoc markup. Writing just `\n` does not render properly.
hrsUnsubmitted
Not Done
Inline Actions

Ah, I see. Thanks. Please forget it.

hrs: Ah, I see. Thanks. Please forget it.
friend = bsearch(&age, friends, len, sizeof(friends[0]), compare);
friend = bsearch((void *)22, &friends, array_size, sizeof(struct person), compare);
assert(strcmp(friend->name, "paul") == 0); assert(strcmp(friend->name, "paul") == 0);
printf("name: %s\enage: %d\en", friend->name, friend->age); printf("name: %s\enage: %d\en", friend->name, friend->age);
friend = bsearch((void *)25, &friends, array_size, sizeof(struct person), compare); age = 25;
assert(strcmp(friend->name, "fred") == 0 || strcmp(friend->name, "anne") == 0); friend = bsearch(&age, friends, len, sizeof(friends[0]), compare);
/*
* For multiple elements with the same key, it is implementation
* defined which will be returned
*/
assert(strcmp(friend->name, "fred") == 0 ||
strcmp(friend->name, "anne") == 0);
printf("name: %s\enage: %d\en", friend->name, friend->age); printf("name: %s\enage: %d\en", friend->name, friend->age);
friend = bsearch((void *)30, &friends, array_size, sizeof(struct person), compare); age = 30;
friend = bsearch(&age, friends, len, sizeof(friends[0]), compare);
assert(friend == NULL); assert(friend == NULL);
printf("friend aged 30 not found\en"); printf("friend aged 30 not found\en");
return (EXIT_SUCCESS);
} }
.Ed .Ed
.Sh SEE ALSO .Sh SEE ALSO
.Xr db 3 , .Xr db 3 ,
.Xr lsearch 3 , .Xr lsearch 3 ,
.Xr qsort 3 .Xr qsort 3
.\" .Xr tsearch 3 .\" .Xr tsearch 3
.Sh STANDARDS .Sh STANDARDS
The The
.Fn bsearch .Fn bsearch
function conforms to function conforms to
.St -isoC . .St -isoC .
View Options

head/sys/dev/hyperv/vmbus/vmbus.c

Show All 26 Lines
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" @(#)bsearch.3 8.3 (Berkeley) 4/19/94 .\" @(#)bsearch.3 8.3 (Berkeley) 4/19/94
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd May 15, 2019 .Dd July 17, 2019
.Dt BSEARCH 3 .Dt BSEARCH 3
.Os .Os
.Sh NAME .Sh NAME
.Nm bsearch .Nm bsearch
.Nd binary search of a sorted table .Nd binary search of a sorted table
.Sh LIBRARY .Sh LIBRARY
.Lb libc .Lb libc
.Sh SYNOPSIS .Sh SYNOPSIS
▲ Show 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
.Bd -literal .Bd -literal
#include <assert.h> #include <assert.h>
#include <stdint.h> #include <stdint.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
struct person { struct person {
char name[5]; const char *name;
hrsUnsubmitted
Done
Inline Actions

Do not use a hard-coded array length here. (const char *) should be enough.

hrs: Do not use a hard-coded array length here. (const char *) should be enough.
int age; int age;
}; };
int static int
compare(const void *key, const void *array_member) compare(const void *a, const void *b)
hrsUnsubmitted
Done
Inline Actions
  • As explained in my other comment, two arguments are supposed to be pointers for an object (the key object and an array member object), not a key "value" and an object.
  • Use simple variable names such as "a" and "b", which are commonly used in this kind of examples.
hrs: - As explained in my other comment, two arguments are supposed to be pointers for an object…
{ {
int age = (intptr_t) key; const int *age;
struct person person = *(struct person *) array_member; const struct person *person;
hrsUnsubmitted
Done
Inline Actions

Two problems:

  • Use a pointer instead of copying the array_member. This causes unnecessary overhead.
  • "const" must be used because array_member is (const void *).

Thus (const struct person *) is better.

hrs: Two problems: - Use a pointer instead of copying the array_member. This causes unnecessary…
return (age - person.age); age = a;
person = b;
return (*age - person->age);
} }
hrsUnsubmitted
Done
Inline Actions

Use main(void) if you do not use the command line arguments.

hrs: Use main(void) if you do not use the command line arguments.
int int
main() main(void)
{ {
hrsUnsubmitted
Not Done
Inline Actions

I think it is better to move the definition of "friends" to just after the declaration of struct person. It is easier for the readers to understand an example which has data structure and contents on a close location.

hrs: I think it is better to move the definition of "friends" to just after the declaration of…
struct person *friend; struct person *friend;
hrsUnsubmitted
Done
Inline Actions

Do not use a hard-coded array length. [] works.

hrs: Do not use a hard-coded array length. [] works.
int age;
/* Sorted array */ /* Sorted array */
struct person friends[6] = { const struct person friends[] = {
{ "paul", 22 }, { "paul", 22 },
{ "anne", 25 }, { "anne", 25 },
{ "fred", 25 }, { "fred", 25 },
{ "mary", 27 }, { "mary", 27 },
{ "mark", 35 }, { "mark", 35 },
{ "bill", 50 } { "bill", 50 }
hrsUnsubmitted
Done
Inline Actions

Do not use sizeof(type) wherever possible. The following is better:

len = sizeof(friends) / sizeof(friends[0]);
hrs: Do not use sizeof(type) wherever possible. The following is better: ``` len = sizeof(friends)…
}; };
const size_t len = sizeof(friends) / sizeof(friends[0]);
hrsUnsubmitted
Done
Inline Actions
  • Create a key object for "22" and pass it as the first argument without casting.
  • Use sizeof(friends[0]) or sizeof("key object name") instead of sizeof(struct person).
hrs: - Create a key object for "22" and pass it as the first argument without casting. - Use sizeof…
size_t array_size = sizeof(friends) / sizeof(struct person); age = 22;
hrsUnsubmitted
Not Done
Inline Actions

Why "\e" is used here? I guess "\n" is intended.

hrs: Why "\e" is used here? I guess "\n" is intended.
jillesUnsubmitted
Not Done
Inline Actions

The \e is required due to mdoc markup. Writing just \n does not render properly.

jilles: The `\e` is required due to mdoc markup. Writing just `\n` does not render properly.
hrsUnsubmitted
Not Done
Inline Actions

Ah, I see. Thanks. Please forget it.

hrs: Ah, I see. Thanks. Please forget it.
friend = bsearch(&age, friends, len, sizeof(friends[0]), compare);
friend = bsearch((void *)22, &friends, array_size, sizeof(struct person), compare);
assert(strcmp(friend->name, "paul") == 0); assert(strcmp(friend->name, "paul") == 0);
printf("name: %s\enage: %d\en", friend->name, friend->age); printf("name: %s\enage: %d\en", friend->name, friend->age);
friend = bsearch((void *)25, &friends, array_size, sizeof(struct person), compare); age = 25;
assert(strcmp(friend->name, "fred") == 0 || strcmp(friend->name, "anne") == 0); friend = bsearch(&age, friends, len, sizeof(friends[0]), compare);
/*
* For multiple elements with the same key, it is implementation
* defined which will be returned
*/
assert(strcmp(friend->name, "fred") == 0 ||
strcmp(friend->name, "anne") == 0);
printf("name: %s\enage: %d\en", friend->name, friend->age); printf("name: %s\enage: %d\en", friend->name, friend->age);
friend = bsearch((void *)30, &friends, array_size, sizeof(struct person), compare); age = 30;
friend = bsearch(&age, friends, len, sizeof(friends[0]), compare);
assert(friend == NULL); assert(friend == NULL);
printf("friend aged 30 not found\en"); printf("friend aged 30 not found\en");
return (EXIT_SUCCESS);
} }
.Ed .Ed
.Sh SEE ALSO .Sh SEE ALSO
.Xr db 3 , .Xr db 3 ,
.Xr lsearch 3 , .Xr lsearch 3 ,
.Xr qsort 3 .Xr qsort 3
.\" .Xr tsearch 3 .\" .Xr tsearch 3
.Sh STANDARDS .Sh STANDARDS
The The
.Fn bsearch .Fn bsearch
function conforms to function conforms to
.St -isoC . .St -isoC .