FFL: Change type of tcp_output() len variable

[jtl]

Summary

In tcp_output, change len from platform-dependent long to fixed-length int32_t.

[bz]

sys/netinet/tcp_output.c

1307

Aehm, no; change the format specifier, don't cast!

[jtl]

sys/netinet/tcp_output.c

1307

You're going to see this in several of my reviews. The "right thing" (TM) to do is to use the PRId32 macro. But, I didn't want to do that, since we don't use it anywhere else in the kernel code.

But, thinking through this more, an int format specifier should work for this. We don't have platforms with ints less than 32 bits, and aren't likely to get one in the future. I'll get all those reviews updated and resubmit.

[jtl]

Remove cast and change format string in KASSERT.

[lstewart]

sys/netinet/tcp_output.c

281

The think I agree with your offline comment about consistency - either make this signed, or change elsewhere to unsigned.

303

Why not min() here and lines 306, 379?

596

(uint32_t)(len + off) here and elsewhere below perhaps?

[jtl]

Committed in rS306769.