Add DOCS OPTION to lang/rust
ClosedPublic
Actions

Authored by riggs on Jul 1 2016, 9:33 PM.

Details

Reviewers

dumbbell
marino
jbeich

Commits

rP417938: Add DOCS OPTION for html docs, bump PORTREVISION

Summary

Add DOCS OPTION to lang/rust

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

riggs updated this revision to Diff 18062.Jul 1 2016, 9:33 PM

riggs retitled this revision from to Add DOCS OPTION to lang/rust.

riggs updated this object.

riggs edited the test plan for this revision. (Show Details)

riggs added reviewers: dumbbell, marino.

Herald added a subscriber: mat. · View Herald TranscriptJul 1 2016, 9:33 PM

@dumbbell : Since DOCS is enabled by default, this will change CONFIGURE_ARGS for rust-nightly as well; please prepare for it
@marino : Some of the installed docs have names / paths that seem freebsd-specific. Could you check whether plist works for DF or do we need some OPSYS replacements in the plist.

The dragonfly package servers are occupied and will be for another day or so. However, is it a good idea to list all these doc files? As opposed to just using PORTDOCS=* ? It seems to be 2000+ lines of html files which is sure to change all the time. I'd use a PORTDOCS wildcard myself so I wouldn't have to add the files to pkg-plist (with the added benefit of not having to worry about filenames that change as a function of op system)

In D7050#147513, @marino wrote:

The dragonfly package servers are occupied and will be for another day or so. However, is it a good idea to list all these doc files? As opposed to just using PORTDOCS=* ? It seems to be 2000+ lines of html files which is sure to change all the time. I'd use a PORTDOCS wildcard myself so I wouldn't have to add the files to pkg-plist (with the added benefit of not having to worry about filenames that change as a function of op system)

I tend to lean towards static plists, but you are probably right. I am testing PORTDOCS wildcard right now, and will update the diff once confirmed that it passes build with and without DOCS option.

Updated patch with PORTDOCS=* instead of static plist.
Builds successfully on FreeBSD. amd64 and i386. Currently build-testing rust-nightly with the patch.

jbeich added a subscriber: jbeich.Jul 2 2016, 4:03 PM

jbeich added inline comments.

lang/rust/Makefile
67 ↗	(On Diff #18073)	Do you still need this section with `PORTDOCS=*`?
80 ↗	(On Diff #18073)	Can you sort items in `OPTIONS_DEFINE`?
100 ↗	(On Diff #18073)	As it's not a conditional variable better move under default `CONFIGURE_ARGS`.
lang/rust/pkg-plist
97 ↗	(On Diff #18073)	What this empty directory is used for? If lang/rust is built with `DOCS=off` other ports still need to create the directory to install there. Otherwise, it seems like an artifact of missing documentation for `extra` library which was actually removed some time ago. Maybe add `${RMDIR}` in `post-configure` or `post-install` target. https://github.com/rust-lang/rust/commit/58e4ab2b33f5 https://github.com/rust-lang/rust/commit/cdd8d4854e52