lang/python35: Update to 3.5.2
AbandonedPublic
Actions

Authored by brnrd on Jun 27 2016, 6:48 PM.

Details

Reviewers

antoine
koobs

Group Reviewers

Python

Summary

lang/python35: Update to 3.5.2

  - Update to version 3.5.2
  - Remove patches now included upstream
  - Update pkg-plist
  - Fix build with LibreSSL / OpenSSL-devel [1]

PR:		205960 [1]
Reviewed_by:	koobs (python)
Approved by:	(python)
Security:	CVE-2016-0772
Security:	8d5368ef-40fe-11e6-b2ec-b499baebfeaf
Differential_Revision:	D6996

Test Plan

poudriere testport

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4364
Build 4411: arc lint + arc unit

Event Timeline

brnrd updated this revision to Diff 17942.Jun 27 2016, 6:48 PM

brnrd retitled this revision from to lang/python35: Update to 3.5.2.

brnrd updated this object.

brnrd edited the test plan for this revision. (Show Details)

brnrd added a reviewer: koobs.

Herald added a subscriber: mat. · View Herald TranscriptJun 27 2016, 6:48 PM

brnrd added a reviewer: Python.Jun 27 2016, 6:48 PM

This removes patches not included upstream

This revision now requires changes to proceed.Jun 27 2016, 7:48 PM

Also the removal of libdata/pkgconfig/python-%%XYDOT%%%%ABI%%.pc from PLIST_FILES and of bin/python%%XYDOT%%-config from plist is a hint that some patches were needed.

After checking, only patch-Modules_zipimport.c went upstream. All other patches are still needed.

Fix/revert removal of most patches

Additionally, test suit results are missing

lang/python35/Makefile
30	This appears to be an unrelated (libressl PR) change being bundled in, which is also not mentioned in the proposed commit message. Please remove/separate
106	Explain removal?

This revision now requires changes to proceed.Jun 28 2016, 2:43 PM

brnrd updated this object.Jul 3 2016, 9:35 AM

brnrd edited edge metadata.

brnrd updated this object.Jul 3 2016, 9:38 AM

Overcome by events rP417798

lang/python35/Makefile
30	Correct, this is for PR 205960. Pulls `-I/usr/local/include` _before_ `-I/usr/include` so build and link time use the same headers+libs
106	Can't yet. Checking