Page MenuHomeFreeBSD

astro/gpsbabel: Update to upstream 1.5.3
ClosedPublic

Authored by cem on Jun 25 2016, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 15, 7:54 PM
Unknown Object (File)
Mon, Jun 24, 6:32 PM
Unknown Object (File)
Jun 23 2024, 1:17 PM
Unknown Object (File)
Jun 20 2024, 9:19 PM
Unknown Object (File)
Jun 19 2024, 7:31 AM
Unknown Object (File)
Jun 19 2024, 7:28 AM
Unknown Object (File)
Jun 19 2024, 7:08 AM
Unknown Object (File)
Jun 19 2024, 7:04 AM
Subscribers

Details

Summary
  • Use system minizip
  • Convert to Github master site
  • Update jeeps patch

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem retitled this revision from to astro/gpsbabel: Update to upstream 1.5.3.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: bdrewery, pgollucci, riggs, AMDmi3, miwi.
astro/gpsbabel/Makefile
7–9 ↗(On Diff #17877)

The USE_GITHUB line should go after the LICENSE block.

Also, you should remove GH_ACCOUNT, it's the default value, and remove GH_TAGNAME and PORTVERSION, replacing them with:

DISTVERSIONPREFIX= ${PORTNAME}_
DISTVERSION= 1_5_3

Update with mat's feedback

cem marked an inline comment as done.Jun 25 2016, 12:58 PM
AMDmi3 requested changes to this revision.Jun 27 2016, 7:48 PM
AMDmi3 edited edge metadata.
AMDmi3 added inline comments.
astro/gpsbabel/Makefile
7 ↗(On Diff #17883)

Preferred order is PORTNAME-DISTVERSIONPREFIX-DISTVERSION-CATEGORIES, see portlint.

23 ↗(On Diff #17883)

These two lines may bereplaced with USES=localbase

26 ↗(On Diff #17883)

LIB_DEPENDS belong between LICENSE block and USE_GITHUB block

40 ↗(On Diff #17883)

I'd just remove headers under zlib/ just to be sure they are not used.

astro/gpsbabel/files/patch-Makefile.in
14 ↗(On Diff #17883)

Um, are you sure above changes are needed? It seems that with --with-zlib=sytem @ZLIB@ in LIBOBJS is replaced with emptiness (instead of "${ZLIB}"), so this list of object files is not used at all, so it seems that you only need to add -lminizip

This revision now requires changes to proceed.Jun 27 2016, 7:48 PM
cem marked 4 inline comments as done.Jun 28 2016, 5:12 AM
cem added inline comments.
astro/gpsbabel/Makefile
40 ↗(On Diff #17883)

They are more intensive to rip out, because they are used as dependencies in Makefile.in regardless of actual use. I'll leave that for future work.

cem edited edge metadata.

Address AMDmi3's feedback.

AMDmi3 edited edge metadata.

Otherwise LGTM.

astro/gpsbabel/files/patch-Makefile.in
14 ↗(On Diff #17883)

MINIZIP= block may also be removed since it's only used in ZLIB which is not used.

This revision is now accepted and ready to land.Jun 28 2016, 3:26 PM
cem marked an inline comment as done.Jun 28 2016, 5:19 PM

I'll remove the MINIZIP diff before commit, thanks for the review!

This revision was automatically updated to reflect the committed changes.