astro/gpsbabel: Update to upstream 1.5.3

[cem]

Summary

• Use system minizip
• Convert to Github master site
• Update jeeps patch

[mat]

astro/gpsbabel/Makefile

7–9 ↗

(On Diff #17877)

The USE_GITHUB line should go after the LICENSE block.

Also, you should remove GH_ACCOUNT, it's the default value, and remove GH_TAGNAME and PORTVERSION, replacing them with:

DISTVERSIONPREFIX= ${PORTNAME}_
DISTVERSION= 1_5_3

[cem]

Update with mat's feedback

[AMDmi3]

astro/gpsbabel/Makefile

7 ↗

(On Diff #17883)

Preferred order is PORTNAME-DISTVERSIONPREFIX-DISTVERSION-CATEGORIES, see portlint.

23 ↗

(On Diff #17883)

These two lines may bereplaced with USES=localbase

26 ↗

(On Diff #17883)

LIB_DEPENDS belong between LICENSE block and USE_GITHUB block

40 ↗

(On Diff #17883)

I'd just remove headers under zlib/ just to be sure they are not used.

astro/gpsbabel/files/patch-Makefile.in

14 ↗

(On Diff #17883)

Um, are you sure above changes are needed? It seems that with --with-zlib=sytem @ZLIB@ in LIBOBJS is replaced with emptiness (instead of "${ZLIB}"), so this list of object files is not used at all, so it seems that you only need to add -lminizip

[cem]

astro/gpsbabel/Makefile

40 ↗

(On Diff #17883)

They are more intensive to rip out, because they are used as dependencies in Makefile.in regardless of actual use. I'll leave that for future work.

[cem]

Address AMDmi3's feedback.

[AMDmi3]

Otherwise LGTM.

astro/gpsbabel/files/patch-Makefile.in

14 ↗

(On Diff #17883)

MINIZIP= block may also be removed since it's only used in ZLIB which is not used.

[cem]

I'll remove the MINIZIP diff before commit, thanks for the review!