Page MenuHomeFreeBSD

Fix gstat's interactive f and q commands
ClosedPublic

Authored by asomers on Jun 23 2016, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 22 2024, 9:26 PM
Unknown Object (File)
Mar 22 2024, 9:26 PM
Unknown Object (File)
Mar 22 2024, 9:26 PM
Unknown Object (File)
Mar 8 2024, 6:14 AM
Unknown Object (File)
Jan 4 2024, 5:28 PM
Unknown Object (File)
Jan 4 2024, 5:28 PM
Unknown Object (File)
Jan 4 2024, 5:28 PM
Unknown Object (File)
Jan 4 2024, 3:32 AM
Subscribers

Details

Summary

curses and libedit don't play well together. After last year's libedit
upgrade in head, they play even less well together. This change resets some
curses settings after they get screwed up by libedit calls. Without it,
gstat's interactive commands require an extra "enter", screw up the terminal
on exit, and screw up the display if the user enters an invalid filter
string.

PR 204852

Test Plan

Run gstat. Verify that the f command works and that the screen looks
correct after entering an invalid filter string at the f prompt. Use q to
quit, and verify that the terminal still works afterwards.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers retitled this revision from to Fix gstat's interactive f and q commands.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added reviewers: bapt, pfg.
pfg edited edge metadata.

Yes I had to revert a libedit upgrade affecting lldb.
It is good to less dependent on libedit's weirdness here.

This revision is now accepted and ready to land.Jun 23 2016, 3:40 PM
This revision was automatically updated to reflect the committed changes.

<3

And here I thought all this was due to libxo integration...