Page MenuHomeFreeBSD
Differential D6849

[bhnd] Fix bhnd_nexus/chipc resource management bugs
ClosedPublic
Actions

Authored by landonf on Jun 15 2016, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 9:47 AM
Unknown Object (File)
Sat, Apr 27, 9:47 AM
Unknown Object (File)
Sat, Apr 27, 9:47 AM
Unknown Object (File)
Sat, Apr 27, 8:18 AM
Unknown Object (File)
Feb 21 2024, 9:22 PM
Unknown Object (File)
Dec 24 2023, 2:11 AM
Unknown Object (File)
Dec 22 2023, 9:47 PM
Unknown Object (File)
Sep 17 2023, 2:15 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS301971: bhnd(4): Fix resource allocation issues exposed by chipc PMU support.
Summary

This resolves a number of issues that came to light when working
on chipc-attached PMU support:

  • Added missing bhnd_nexus bhnd_bus_deactivate_resource implementation.
  • Delete all chipc children on attachment failure.
  • Drop a CHIPC_UNLOCK() accidentally left behind after lifting synchronization into the chipc region refcounting API.
  • Fix re-allocation of chipc resources. Previously, the resource ID was reset to -1 on release, preventing later re-allocation.
Test Plan

Tested on:

  • BCM43225
  • WGT634U
  • RT-N16
  • RT-N53

Tinderbox kernel build is in-progress.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

landonf updated this revision to Diff 17592.Jun 15 2016, 12:02 AM
landonf retitled this revision from to [bhnd] Fix bhnd_nexus/chipc resource management bugs.
landonf updated this object.
landonf edited the test plan for this revision. (Show Details)
landonf added a reviewer: adrian.
Herald added a subscriber: imp. · View Herald TranscriptJun 15 2016, 12:02 AM
landonf added a child revision: D6850: siba(4): Adopt a bcma-compatible mapping of bhnd(4) port/region identifiers..Jun 15 2016, 12:15 AM
adrian edited edge metadata.Jun 15 2016, 12:20 AM

looks good. email re@freebsd.org with a patch and a description of it so they can approve committing it to -head.

adrian accepted this revision.Jun 15 2016, 12:20 AM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2016, 12:20 AM
Closed by commit rS301971: bhnd(4): Fix resource allocation issues exposed by chipc PMU support. (authored by landonf). · Explain WhyJun 16 2016, 7:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
bhnd/
16 lines
cores/
chipc/
6 lines
8 lines
29 lines

Diff 17643

View Options

head/sys/dev/bhnd/bhnd_nexus.c

Loading...
View Options

head/sys/dev/bhnd/cores/chipc/chipc.c

Loading...
View Options

head/sys/dev/bhnd/cores/chipc/chipc_private.h

Loading...
View Options

head/sys/dev/bhnd/cores/chipc/chipc_subr.c

Loading...