Page MenuHomeFreeBSD

vt(4): Run vt_timer only when there's something to draw
ClosedPublic

Authored by dumbbell on Aug 24 2014, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 1:02 AM
Unknown Object (File)
Nov 5 2024, 5:18 PM
Unknown Object (File)
Oct 27 2024, 5:25 AM
Unknown Object (File)
Oct 21 2024, 6:21 AM
Unknown Object (File)
Oct 18 2024, 6:30 AM
Unknown Object (File)
Oct 5 2024, 9:40 AM
Unknown Object (File)
Oct 5 2024, 1:55 AM
Unknown Object (File)
Oct 2 2024, 8:04 PM
Subscribers
None

Details

Reviewers
ray
emaste
Summary

The goal is to only schedule vt_timer when the screen needs a refresh.

Do you see missing places where the timer should be restarted?

Test Plan

I use the following DTrace script to see when the timer runs:

#!/usr/sbin/dtrace -s

#pragma D option quiet
#pragma D option bufsize=16m
#pragma D option dynvarsize=16m

fbt:kernel:vt_flush:entry
{
  printf(".");
}

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dumbbell retitled this revision from to vt(4): Run vt_timer only when there's something to draw.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: emaste, ray.

Agree, too.
Save world using less electric power :)

ray edited edge metadata.

Looks good!

This revision is now accepted and ready to land.Aug 26 2014, 12:03 PM

Thanks, committed in r270707!