Page MenuHomeFreeBSD

vt(4): Run vt_timer only when there's something to draw
ClosedPublic

Authored by dumbbell on Aug 24 2014, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 11 2023, 10:23 PM
Unknown Object (File)
May 9 2023, 10:33 AM
Unknown Object (File)
Apr 9 2023, 6:15 AM
Unknown Object (File)
Mar 23 2023, 6:39 AM
Unknown Object (File)
Dec 14 2022, 12:31 AM
Unknown Object (File)
Nov 30 2022, 3:50 AM
Unknown Object (File)
Apr 5 2017, 12:43 PM
Unknown Object (File)
Feb 27 2017, 8:56 PM
Subscribers
None

Details

Reviewers
ray
emaste
Summary

The goal is to only schedule vt_timer when the screen needs a refresh.

Do you see missing places where the timer should be restarted?

Test Plan

I use the following DTrace script to see when the timer runs:

#!/usr/sbin/dtrace -s

#pragma D option quiet
#pragma D option bufsize=16m
#pragma D option dynvarsize=16m

fbt:kernel:vt_flush:entry
{
  printf(".");
}

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dumbbell retitled this revision from to vt(4): Run vt_timer only when there's something to draw.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: emaste, ray.

Agree, too.
Save world using less electric power :)

ray edited edge metadata.

Looks good!

This revision is now accepted and ready to land.Aug 26 2014, 12:03 PM

Thanks, committed in r270707!