Page MenuHomeFreeBSD

multimedia/vdr-plugin-osdpip: Update to 0.1.2 and add patch-ffmpeg3
ClosedPublic

Authored by woodsb02 on Jun 11 2016, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 1:29 AM
Unknown Object (File)
Thu, Dec 26, 6:40 AM
Unknown Object (File)
Nov 23 2024, 10:35 AM
Unknown Object (File)
Nov 23 2024, 10:35 AM
Unknown Object (File)
Nov 23 2024, 10:35 AM
Unknown Object (File)
Nov 23 2024, 10:35 AM
Unknown Object (File)
Nov 23 2024, 10:22 AM
Unknown Object (File)
Oct 27 2024, 9:38 PM
Subscribers
None

Details

Summary

multimedia/vdr-plugin-osdpip:

  • Update to 0.1.2
  • Add patch to fix build with FFmpeg 3.0.x once it lands in ports tree
  • Add LICENSE and LICENSE_FILE
  • Remove obsolete patches for i18n.h, receiver.c and part of Makefile
  • Merge patch-vdr-osdpip-0.1.0 into patch-Makefile
  • Reformulate remaining patches to not require PATCH_STRIP=-p1
  • Fix WWW in pkg-descr
Test Plan

poudriere testport multimedia/vdr-plugin-osdpip

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

woodsb02 retitled this revision from to multimedia/vdr-plugin-osdpip: Update to 0.1.2 and add patch-ffmpeg3.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: mat, adamw, koobs.
multimedia/vdr-plugin-osdpip/Makefile
21 ↗(On Diff #17506)

If there's PORTDOCS, there should be a DOCS option.

As per comment from adamw:

  • Add DOCS option and post-install-DOCS-on target
multimedia/vdr-plugin-osdpip/Makefile
35 ↗(On Diff #17516)

An empty post-install looks strange. Should it be the following instead?

post-instal-DOCS-on: post-install-pluginlocales
multimedia/vdr-plugin-osdpip/Makefile
35 ↗(On Diff #17516)

I think it is better with the empty post-install target which calls the post-install-pluginlocales target. This will ensure that if any post-install contents is added in the future people will put it in this section, ensuring that the post-install-pluginlocales always executes before post-install.

Also, there is already an empty post-patch target above.

Happy to go either way with this one - just explaining my thoughts.

adamw edited edge metadata.

Sounds like good logic to me. I'm sold.

This revision is now accepted and ready to land.Jun 11 2016, 5:02 PM
This revision was automatically updated to reflect the committed changes.