Differential D6782

libefi be more verbose when registering efi disk handles
ClosedPublic
Actions

Authored by manu on Jun 9 2016, 12:29 AM.

Details

Reviewers

andrew

Commits

rS301714: Print a message when the efi disk isn't a logical partition.

Summary

Print a message when the efi disk isn't a logical partition.

Test Plan

Tested on beaglebone black with u-boot efi implementation.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu updated this revision to Diff 17446.Jun 9 2016, 12:29 AM

manu retitled this revision from to libefi be more verbose when registering efi disk handles.

manu updated this object.

manu edited the test plan for this revision. (Show Details)

manu added a reviewer: andrew.

manu set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2016, 12:29 AM

Approved

This revision is now accepted and ready to land.Jun 9 2016, 12:33 AM

Closed by commit rS301714: Print a message when the efi disk isn't a logical partition. (authored by manu). · Explain WhyJun 9 2016, 2:03 AM

This revision was automatically updated to reflect the committed changes.

imp added inline comments.Jun 9 2016, 2:21 AM

head/sys/boot/efi/libefi/efipart.c
123–124 ↗	(On Diff #17449)	Why on earth would you do this? When it isn't a logical partition, it's a real disk. Our systems have 36 disks in them, so this will spam-up the console log with 36 useless lines...

Revision Contents
Changeset List

Path

Size

sys/

boot/

efi/

libefi/

efipart.c

5 lines

Diff 17446

View Options

sys/boot/efi/libefi/efipart.c

libefi be more verbose when registering efi disk handlesClosedPublicActions