Page MenuHomeFreeBSD
Differential D6735

Fix bhnd(4) MIPS core attachment issues
ClosedPublic
Actions

Authored by landonf on Jun 6 2016, 12:10 AM.
Tags
None
Referenced Files
F154513719: D6735.id17339.diff
Tue, Apr 28, 7:27 PM
F154510861: D6735.id17339.diff
Tue, Apr 28, 7:21 PM
Unknown Object (File)
Mon, Apr 27, 3:12 AM
Unknown Object (File)
Thu, Apr 16, 5:23 PM
Unknown Object (File)
Thu, Apr 16, 5:17 PM
Unknown Object (File)
Wed, Apr 15, 12:34 PM
Unknown Object (File)
Fri, Apr 10, 4:15 PM
Unknown Object (File)
Mon, Apr 6, 4:08 PM
View All Files
Subscribers
imp

Details

Reviewers
mizhka
adrian
Commits
rS301698: bhnd(4): Fix mips/broadcom core matching and bus pass order.
Summary

Fixes a number of minor MIPS core attachment issues based on conversation with
mizhka.

Issues fixed:

  • Fixed incorrect MIPS74k vendor ID in the bhnd core descriptor tables
  • Improved MIPS3302 device description
  • Set the bhnd nexus drivers' bus pass to allow early probing of the CPU core.
  • Fix MIPS core driver's matching against MIPS/MIPS33 cores.
  • Disabled matching the MIPS core driver on non-SoC devices
  • Enabled BUS_PASS_CPU on the MIPS core driver ensure correct attach order.
Test Plan

Tested locally against:

  • RT-N16
  • WGT634U
  • BCM4331
  • BCM4312

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

landonf updated this revision to Diff 17338.Jun 6 2016, 12:10 AM
landonf retitled this revision from to Fix bhnd(4) MIPS core attachment issues.
landonf updated this object.
landonf edited the test plan for this revision. (Show Details)
landonf added reviewers: adrian, mizhka.
Herald added a subscriber: imp. · View Herald TranscriptJun 6 2016, 12:10 AM
landonf updated this revision to Diff 17339.Jun 6 2016, 1:34 AM

Integrate BHND_*_DEVICE fixes.

landonf added a parent revision: D6736: Add a vendor parameter to BHND_DEVICE, replacing vendor-specific BHND_*_DEVICE macros..Jun 6 2016, 1:38 AM
mizhka accepted this revision.Jun 6 2016, 5:19 PM
mizhka edited edge metadata.
landonf updated this object.Jun 6 2016, 7:03 PM
landonf edited the test plan for this revision. (Show Details)
landonf edited edge metadata.
adrian accepted this revision.Jun 6 2016, 11:17 PM
adrian edited edge metadata.

ok!

This revision is now accepted and ready to land.Jun 6 2016, 11:17 PM
Closed by commit rS301698: bhnd(4): Fix mips/broadcom core matching and bus pass order. (authored by landonf). · Explain WhyJun 8 2016, 9:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
bhnd/
bcma/
3 lines
4 lines
siba/
3 lines
mips/
broadcom/
19 lines

Diff 17441

View Options

head/sys/dev/bhnd/bcma/bcma_nexus.c

Loading...
View Options

head/sys/dev/bhnd/bhnd_subr.c

Loading...
View Options

head/sys/dev/bhnd/siba/siba_nexus.c

Loading...
View Options

head/sys/mips/broadcom/bcm_mipscore.c

Loading...