Page MenuHomeFreeBSD
Differential D6734

Use the in-tree sys/elf_common.h to build libelftc.
ClosedPublic
Actions

Authored by bdrewery on Jun 5 2016, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 8:24 AM
Unknown Object (File)
Sun, Apr 21, 6:08 AM
Unknown Object (File)
Mar 10 2024, 2:28 PM
Unknown Object (File)
Mar 10 2024, 2:28 PM
Unknown Object (File)
Mar 10 2024, 2:28 PM
Unknown Object (File)
Mar 7 2024, 8:31 PM
Unknown Object (File)
Dec 20 2023, 12:29 AM
Unknown Object (File)
Dec 12 2023, 2:03 AM
View All 53 Files
Subscribers
allanjude
imp

Details

Reviewers
emaste
Commits
rS301471: Use the in-tree sys/elf_common.h to build libelftc.
Summary

This fixes build failures on older releases that lack various
definitions such as EM_AARCH64 (which was unfixed before this).

Revert all of the recent compatibility changes that worked around this
problem.

This uses the same method of using the in-tree header as lib/libelf,
lib/libdwarf and usr.bin/readelf.

Sponsored by: EMC / Isilon Storage Division

Test Plan

Built from 8.4.

Note that the EM_AARCH64 failure was reported by Allan Jude for building
from 9.3.

/usr/src/contrib/elftoolchain/libelftc/elftc_reloc_type_str.c:95: error: 'EM_AARCH64' undeclared (first use in this function)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdrewery updated this revision to Diff 17336.Jun 5 2016, 8:37 PM
bdrewery retitled this revision from to Use the in-tree sys/elf_common.h to build libelftc..
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
bdrewery added a reviewer: emaste.
bdrewery added a subscriber: allanjude.
Herald added a subscriber: imp. · View Herald TranscriptJun 5 2016, 8:37 PM
emaste accepted this revision.Jun 5 2016, 8:58 PM
emaste edited edge metadata.

OK.

I'd to find a clean way (that's acceptable upstream too) to use the ELF Tool Chain definitions common/elfdefinitions.h instead of sys/elf_common.h. But using the same approach as in libelf/libdwarf is fine right now.

This revision is now accepted and ready to land.Jun 5 2016, 8:58 PM
bdrewery added a comment.Jun 5 2016, 9:03 PM

I think the more proper solution is to just install this file with libegacy. For now I will go with this pattern since it is used in 3 other places.

Closed by commit rS301471: Use the in-tree sys/elf_common.h to build libelftc. (authored by bdrewery). · Explain WhyJun 5 2016, 11:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
contrib/
elftoolchain/
brandelf/
5 lines
elfcopy/
5 lines
elfdump/
8 lines
libdwarf/
5 lines
libelftc/
8 lines
readelf/
9 lines
lib/
libelftc/
13 lines

Diff 17337

View Options

head/contrib/elftoolchain/brandelf/brandelf.c

Loading...
View Options

head/contrib/elftoolchain/elfcopy/main.c

Loading...
View Options

head/contrib/elftoolchain/elfdump/elfdump.c

Loading...
View Options

head/contrib/elftoolchain/libdwarf/libdwarf_reloc.c

Loading...
View Options

head/contrib/elftoolchain/libelftc/elftc_reloc_type_str.c

Loading...
View Options

head/contrib/elftoolchain/readelf/readelf.c

Loading...
View Options

head/lib/libelftc/Makefile

Loading...