Differential D6727

Eliminate unnecessary sleep(10) in newsyslog when -R and -s are specified
ClosedPublic
Actions

Authored by dab on Jun 4 2016, 2:03 PM.

Details

Reviewers

vangyzen

Commits

rS301532: newsyslog: Eliminate unnecessary sleep(10) when -R and -s are specified

Summary

See PR210020

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dab updated this revision to Diff 17305.Jun 4 2016, 2:03 PM

dab retitled this revision from to Eliminate unnecessary sleep(10) in newsyslog when -R and -s are specified.

dab updated this object.

dab edited the test plan for this revision. (Show Details)

dab set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJun 4 2016, 2:03 PM

dab added a reviewer: vangyzen.Jun 4 2016, 2:05 PM

No changes to actual diff; just trying to get context (pardon my unfamiliarity with phabricator).

One could argue that simply testing for !nosignal is enough here (line 336). If the daemon(s) is(are) not being signaled then what good does the sleep "to allow daemon(s) to close log file(s)" do since the daemon(s) is(are) not being informed of the rotation? However, I started with the conservative approach.

dab added a comment.Jun 5 2016, 2:32 PM

This comment was removed by dab.

Closed by commit rS301532: newsyslog: Eliminate unnecessary sleep(10) when -R and -s are specified (authored by vangyzen). · Explain WhyJun 6 2016, 10:54 PM

This revision was automatically updated to reflect the committed changes.