Change python from a run to a build dep of www/node. The current version of
node doesn't install any Python files.
Details
Details
- Reviewers
pi - Commits
- rP416938: Change python from a run to a build dep of www/node
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 4090 Build 4133: arc lint + arc unit
Event Timeline
Comment Actions
You should bump PORTREVISION so that the package gets rebuilt and the runtime dependency gets dropped.
| www/node/Makefile | ||
|---|---|---|
| 5 | FYI, the port is currently at 6.2.1_1, so you probably want to update the patch and bump the PORTREVISION again. | |
Comment Actions
If all that is needed is that small change, please don't bother with the update, this can be done easily.
Has this change maintainer approval ?
Comment Actions
The maintainer approved this review by email. Now I just need approval from a ports committer.
Comment Actions
The UI of phabricator really isn't my thing, sorry if I look confused. Do you need approval from a ports committer or do you need a commit from a ports committer ?
Comment Actions
I guess it's too late to mention that the other www/node* ports could benefit from the same change? :P
Comment Actions
I didn't think of that at the time, because I don't use any of those ports. But in hindsight it looks like they could all use the same change.
Comment Actions
@bradleythughes_fastmail.fm Do you think it is worth doing since all of them are going to expire? Except for www/node4, that one is probably worth doing.