Page MenuHomeFreeBSD
Differential D6699

Change python from a run to a build dep of www/node
ClosedPublic
Actions

Authored by asomers on Jun 2 2016, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 15 2024, 11:28 AM
Unknown Object (File)
Oct 20 2024, 10:49 AM
Unknown Object (File)
Oct 2 2024, 5:48 PM
Unknown Object (File)
Oct 2 2024, 9:59 AM
Unknown Object (File)
Sep 30 2024, 11:29 PM
Unknown Object (File)
Sep 30 2024, 11:27 PM
Unknown Object (File)
Sep 27 2024, 12:59 PM
Unknown Object (File)
Sep 24 2024, 4:46 AM
View All 52 Files
Subscribers
bhughes
brd
mat

Details

Reviewers
pi
Commits
rP416938: Change python from a run to a build dep of www/node
Summary

Change python from a run to a build dep of www/node. The current version of
node doesn't install any Python files.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 17248.Jun 2 2016, 10:16 PM
asomers retitled this revision from to Change python from a run to a build dep of www/node.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: pi.
asomers added a subscriber: brd.
Herald added a subscriber: mat. · View Herald TranscriptJun 2 2016, 10:16 PM
mat added a comment.Jun 2 2016, 10:57 PM

You should bump PORTREVISION so that the package gets rebuilt and the runtime dependency gets dropped.

asomers updated this revision to Diff 17272.Jun 3 2016, 2:22 PM

Bump PORTREVISION

bhughes added a subscriber: bhughes.Jun 15 2016, 8:21 PM
bhughes added inline comments.
www/node/Makefile
5 ↗(On Diff #17272)

FYI, the port is currently at 6.2.1_1, so you probably want to update the patch and bump the PORTREVISION again.

asomers updated this revision to Diff 17608.Jun 15 2016, 8:32 PM

Resolve conflicts with recent commits

pi edited edge metadata.Jun 15 2016, 8:32 PM

If all that is needed is that small change, please don't bother with the update, this can be done easily.

Has this change maintainer approval ?

bhughes added a comment.Jun 15 2016, 8:33 PM

Has this change maintainer approval ?

Yes, it does :)

asomers added a comment.Jun 15 2016, 8:33 PM

The maintainer approved this review by email. Now I just need approval from a ports committer.

pi added a comment.Jun 15 2016, 8:35 PM

The UI of phabricator really isn't my thing, sorry if I look confused. Do you need approval from a ports committer or do you need a commit from a ports committer ?

pi accepted this revision.Jun 15 2016, 8:35 PM
pi edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2016, 8:35 PM
asomers added a comment.Jun 15 2016, 8:38 PM

I'm a src committer, so I only need approval from a ports committer. Thanks pi.

Closed by commit rP416938: Change python from a run to a build dep of www/node (authored by asomers). · Explain WhyJun 15 2016, 9:32 PM
This revision was automatically updated to reflect the committed changes.
bhughes added a comment.Jun 15 2016, 9:44 PM

I guess it's too late to mention that the other www/node* ports could benefit from the same change? :P

asomers added a comment.Jun 15 2016, 9:54 PM
In D6699#143973, @bradleythughes_fastmail.fm wrote:

I guess it's too late to mention that the other www/node* ports could benefit from the same change? :P

I didn't think of that at the time, because I don't use any of those ports. But in hindsight it looks like they could all use the same change.

brd added a comment.Jun 17 2016, 2:40 PM

@bradleythughes_fastmail.fm Do you think it is worth doing since all of them are going to expire? Except for www/node4, that one is probably worth doing.

Revision Contents
Changeset List

PathSize
head/
www/
node/
4 lines

Diff 17612

View Options

head/www/node/Makefile

Loading...