Add option helper for PLIST_SUB
ClosedPublic

Press ? to show keyboard shortcuts.
Author
antoine
Reviewers
mat
Project Reviewers
portmgr
Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Commits
rP365573: Add an option helper for PLIST_SUB
Apply Patch
arc patch D665
Arcanist Project
Restricted Arcanist Project
Subscribers
koobs
Projects
None
Summary

Add option helper for PLIST_SUB
Suggested by koobs

antoine created this revision.Via ConduitAug 21 2014, 2:12 PM
antoine added a reviewer: koobs.
Herald added a reviewer: portmgr. · View Herald TranscriptVia HeraldAug 21 2014, 2:12 PM
koobs added a comment.Via WebAug 21 2014, 2:35 PM

This is super awesome, thanks for creating this @antoine!

Will help remove this kind of thing:

.if ${PORT_OPTIONS:MPYTHON}
PLIST_SUB+=     PYTHON_VER="${PYTHON_VER}" VERSION="${PORTVERSION}"
.endif
koobs accepted this revision.Via WebAug 21 2014, 2:35 PM
mat accepted this revision.Via WebAug 21 2014, 4:07 PM
mat added a reviewer: mat.
This revision has a positive review.Via WebAug 21 2014, 4:07 PM
mat added a comment.Via WebAug 21 2014, 4:30 PM

Please, also add it to the porter's handbook, in head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml about line 4188 (and add INFO too, it kinda crept through.)

antoine planned changes to this revision.Via WebAug 21 2014, 4:54 PM

Mk/bsd.apache.mk:${module}_PLIST_SUB= "@comment "
Mk/bsd.apache.mk:${module}_PLIST_SUB= ""
Mk/bsd.apache.mk:PLIST_SUB+= MOD_${module}=${${module}_PLIST_SUB}
x11-themes/slim-themes/Makefile:NEW_PLIST_SUB:= ${PLIST_SUB} ${n}=""
x11-themes/slim-themes/Makefile:PLIST_SUB:= ${NEW_PLIST_SUB}
x11-themes/slim-themes/Makefile:NEW_PLIST_SUB:= ${PLIST_SUB} ${n}="@comment "
x11-themes/slim-themes/Makefile:PLIST_SUB:= ${NEW_PLIST_SUB}

antoine updated this revision to Diff 1202.Via ConduitAug 21 2014, 5:37 PM

Rename a few variables to avoid confusion

This revision has a positive review.Via ConduitAug 21 2014, 5:37 PM
koobs added a subscriber: koobs.Via WebAug 21 2014, 5:39 PM

Unqualified to review this shell magic. Taking my name off reviewers (previous change accepted).

koobs resigned from this revision.Via WebAug 21 2014, 5:39 PM
koobs removed a reviewer: koobs.
antoine closed this revision.Via DaemonsAug 21 2014, 6:07 PM
antoine updated this revision to Diff 1203.

Closed by commit rP365573 (authored by @antoine).

Revision Update History

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 11198365560Aug 21 2014, 2:12 PM
Diff 21202365572Rename a few variables to avoid confusionAug 21 2014, 5:37 PM
Diff 31203365572Commit rP365573Aug 21 2014, 6:06 PM

Table of Contents

PathCoverage (All)Coverage (Touched)
Mhead/Mk/bsd.apache.mk (6 lines)--
Mhead/Mk/bsd.options.mk (4 lines)--
Mhead/x11-themes/slim-themes/Makefile (8 lines)--

Diff 1203

head/Mk/bsd.apache.mk

Loading...

head/Mk/bsd.options.mk

Loading...

head/x11-themes/slim-themes/Makefile

Loading...

Add Comment