Add option helper for PLIST_SUB
ClosedPublic

Authored by antoine on Aug 21 2014, 2:12 PM.

Details

Reviewers
mat
Project Reviewers
portmgr
Commits
rP365573: Add an option helper for PLIST_SUB
Apply Patch
arc patch D665
Summary

Add option helper for PLIST_SUB
Suggested by koobs

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
antoine created this revision.Aug 21 2014, 2:12 PM
antoine added a reviewer: koobs.
koobs added a comment.Aug 21 2014, 2:35 PM

This is super awesome, thanks for creating this @antoine!

Will help remove this kind of thing:

.if ${PORT_OPTIONS:MPYTHON}
PLIST_SUB+=     PYTHON_VER="${PYTHON_VER}" VERSION="${PORTVERSION}"
.endif
koobs accepted this revision.Aug 21 2014, 2:35 PM
mat accepted this revision.Aug 21 2014, 4:07 PM
mat added a reviewer: mat.
This revision has a positive review.Aug 21 2014, 4:07 PM
mat added a comment.Aug 21 2014, 4:30 PM

Please, also add it to the porter's handbook, in head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml about line 4188 (and add INFO too, it kinda crept through.)

antoine planned changes to this revision.Aug 21 2014, 4:54 PM

Mk/bsd.apache.mk:${module}_PLIST_SUB= "@comment "
Mk/bsd.apache.mk:${module}_PLIST_SUB= ""
Mk/bsd.apache.mk:PLIST_SUB+= MOD_${module}=${${module}_PLIST_SUB}
x11-themes/slim-themes/Makefile:NEW_PLIST_SUB:= ${PLIST_SUB} ${n}=""
x11-themes/slim-themes/Makefile:PLIST_SUB:= ${NEW_PLIST_SUB}
x11-themes/slim-themes/Makefile:NEW_PLIST_SUB:= ${PLIST_SUB} ${n}="@comment "
x11-themes/slim-themes/Makefile:PLIST_SUB:= ${NEW_PLIST_SUB}

antoine updated this revision to Diff 1202.Aug 21 2014, 5:37 PM

Rename a few variables to avoid confusion

This revision has a positive review.Aug 21 2014, 5:37 PM
koobs added a subscriber: koobs.Aug 21 2014, 5:39 PM

Unqualified to review this shell magic. Taking my name off reviewers (previous change accepted).

koobs resigned from this revision.Aug 21 2014, 5:39 PM
koobs removed a reviewer: koobs.
antoine closed this revision.Aug 21 2014, 6:07 PM
antoine updated this revision to Diff 1203.

Closed by commit rP365573 (authored by @antoine).