Differential D6573

hyperv/et: Fix STIMER0 operations.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on May 26 2016, 7:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 6, 10:33 PM

	Unknown Object (File)
	Fri, May 1, 11:29 AM

	Unknown Object (File)
	Sat, Apr 25, 7:52 AM

	Unknown Object (File)
	Sat, Apr 25, 12:17 AM

	Unknown Object (File)
	Fri, Apr 24, 2:33 PM

	Unknown Object (File)
	Thu, Apr 23, 12:42 AM

	Unknown Object (File)
	Tue, Apr 21, 2:13 PM

	Unknown Object (File)
	Mon, Apr 20, 4:39 PM

Subscribers

None

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger

Commits

rS300987: hyperv/et: Fix STIMER0 operations.

Summary

Make sure that STIMER0 is disabled before writting to it, since writing to an enabled STIMER will result in undefined behaviour.
It is unnecessary to reconfigure STIMER0 upon each et_start().
Make sure that MSR_HV_REF_TIME_COUNT will not return 0, since writing 0 to STIMER_COUNT will disable the target STIMER.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 16897.May 26 2016, 7:19 AM

sepherosa_gmail.com retitled this revision from to hyperv/et: Fix STIMER0 operations..

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.

sepherosa_gmail.com updated this revision to Diff 16963.May 27 2016, 2:50 AM

Closed by commit rS300987: hyperv/et: Fix STIMER0 operations. (authored by sephe). · Explain WhyMay 30 2016, 8:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hyperv/

vmbus/

53 lines

Diff 17098

head/sys/dev/hyperv/vmbus/hv_et.c

Loading...