[GEOM/disk] Add function to find disk by device softc
AbandonedPublic
Actions

Authored by mizhka on May 16 2016, 10:15 PM.

Details

Reviewers

sobomax
adrian

Summary

Hi,

This patch introduces simple function to find disk by device softc.

Use case is geom_flashmap. It provides way to register callback to identify slices on flash device. It passes device_t into callback, but flash size is required to calculate end of memory-mapped flash region. This functions helps to retrieve flash size of any device (CFI, SPI and so on).

Test Plan

Tested on Asus RT-N53 (SPI / mx25l)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mizhka updated this revision to Diff 16414.May 16 2016, 10:15 PM

mizhka retitled this revision from to [GEOM/disk] Add function to find disk by device softc.

mizhka updated this object.

mizhka edited the test plan for this revision. (Show Details)

mizhka added reviewers: adrian, sobomax.

mizhka set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMay 16 2016, 10:15 PM

mizhka added a child revision: D6250: [BHND] ChipCommon: Resource managers, Serial & Parallel Flash support, .May 16 2016, 10:16 PM

mizhka mentioned this in D6243: [SPI Flash] Add interface to fetch flash size.

Why not just store the disk pointer in the softc?

I see 2 disadvantages of softc->disk reference:

It requires setting of disks for all possible drivers (cfi, mx25l, at45 and etc.).
fetch of disk will require casting+switch logic for all possible drivers.

Proposed method is isolated from driver implementation and softc structure type.

landon_landonf.org added a subscriber: landon_landonf.org.May 17 2016, 9:39 PM

mizhka abandoned this revision.May 27 2016, 1:03 AM

landon_landonf.org removed a child revision: D6250: [BHND] ChipCommon: Resource managers, Serial & Parallel Flash support, .May 27 2016, 6:14 PM