Page MenuHomeFreeBSD

Don't store generated firmware object files in the source directory.
ClosedPublic

Authored by jhb on May 9 2016, 10:13 PM.
Tags
None
Referenced Files
F103244139: D6285.id.diff
Fri, Nov 22, 2:05 PM
Unknown Object (File)
Thu, Oct 31, 3:23 PM
Unknown Object (File)
Sep 21 2024, 4:31 AM
Unknown Object (File)
Sep 14 2024, 11:52 PM
Unknown Object (File)
Sep 14 2024, 11:52 PM
Unknown Object (File)
Sep 9 2024, 11:28 AM
Unknown Object (File)
Sep 9 2024, 3:45 AM
Unknown Object (File)
Sep 8 2024, 11:02 PM
Subscribers
None

Details

Summary

Don't store generated firmware object files in the source directory.

Trim the leading directory of a firmware source file from the resulting
target object file name so the object file is stored in the object
directory. Previously, using 'FIRMWS= /path/to/fw.bin:fw.bin' would
store the generated 'fw.bin.fwo' file in the /path/to directory. Now
it stores it in the object directory of the kernel module being built.

Test Plan
  • Build a firmware module that doesn't use uudecode to extract a file into the CWD first with a read-only source tree.
  • Still need to do a test run of this fix in tinderbox.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb retitled this revision from to Don't store generated firmware object files in the source directory..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added reviewers: bdrewery, imp, adrian.
bdrewery edited edge metadata.

Seems ok.

This revision is now accepted and ready to land.May 10 2016, 12:10 AM
This revision was automatically updated to reflect the committed changes.