Add a patch to address upstream bug CFE-1803 (Storage promises do not unmount the filesystem as promised)
ClosedPublic
Actions

Authored by skreuzer on May 3 2016, 1:51 PM.

Details

Reviewers

gjb
cy

Commits

rP414601: Add a patch to address upstream bug CFE-1803 (Storage promises do not unmount

Summary

GetGlobalMountedFSList returns a static list, which is initially
length zero; LoadMountInfo fills that list in with the output of the mount
command. But the sense of the first check is backwards. We should fill in the
list if it is empty, not if it is non-empty.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

skreuzer updated this revision to Diff 15850.May 3 2016, 1:51 PM

skreuzer retitled this revision from to Add a patch to address upstream bug CFE-1803 (Storage promises do not unmount the filesystem as promised).

skreuzer updated this object.

skreuzer added reviewers: gjb, cy.

Herald added a subscriber: mat. · View Herald TranscriptMay 3 2016, 1:51 PM

Looks good.

This patch should be backported to at least cfengine36 and cfengin37.

In D6186#131958, @cy wrote:

Looks good.

This patch should be backported to at least cfengine36 and cfengin37.

Yeah, I plan on doing this but we don't run cfe 3.6 or 3.7 anymore so I need to build a test environment to make sure it still does what I expect it to do. We also opened a pull request upstream to get this patch merged back into cfengine/core

Closed by commit rP414601: Add a patch to address upstream bug CFE-1803 (Storage promises do not unmount (authored by skreuzer). · Explain WhyMay 4 2016, 12:52 PM

This revision was automatically updated to reflect the committed changes.

skreuzer mentioned this in rP414601: Add a patch to address upstream bug CFE-1803 (Storage promises do not unmount.