libthr: Remove deadcode in join_common
AcceptedPublic
Actions

Authored by aokblast on Tue, Oct 13, 7:42 PM.

Tags

None

Referenced Files

	F176322452: D60711.diff
	Sat, Oct 17, 10:10 PM

	F176245903: D60711.id189781.diff
	Sat, Oct 17, 7:24 AM

	Unknown Object (File)
	Thu, Oct 15, 11:51 PM

	Unknown Object (File)
	Wed, Oct 14, 10:08 AM

	Unknown Object (File)
	Wed, Oct 14, 5:39 AM

	Unknown Object (File)
	Wed, Oct 14, 4:33 AM

	Unknown Object (File)
	Wed, Oct 14, 12:09 AM

	Unknown Object (File)
	Tue, Oct 13, 11:37 PM

View All 12 Files

Subscribers

imp

Details

Reviewers

kib

Summary

The while loop previous can only be break when ret == ETIMEDOUT. They
never produce EBUSY. Remove the deadcode here.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 78141
Build 75024: arc lint + arc unit

Event Timeline

aokblast created this revision.Tue, Oct 13, 7:42 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 13, 7:42 PM

aokblast requested review of this revision.Tue, Oct 13, 7:42 PM

Harbormaster completed remote builds in B78141: Diff 189781.Tue, Oct 13, 7:42 PM

I am not completely sure that EBUSY is not possible, because it can come from umtx_op(UMTX_OP_WAIT) when tid is also set to TID_TERMINATED. But indeed I do not think that it matter.
It could be that we should only execute 'else { ret = 0;' block when tid is TID_TERMINATED, and really check for ret != 0 in the if().

In fact, if the loop exited due to TID_TERMINATED, then ret does not matter.

This revision is now accepted and ready to land.Wed, Oct 14, 5:39 AM

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_join.c

2 lines

Diff 189781

View Options

lib/libthr/thread/thr_join.c

libthr: Remove deadcode in join_commonAcceptedPublicActions