i386 lib/msun: SSE2 is always present on amd64 host
AcceptedPublic
Actions

Authored by kib on Tue, Oct 13, 3:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 16, 5:25 AM

	Unknown Object (File)
	Fri, Oct 16, 2:25 AM

	Unknown Object (File)
	Thu, Oct 15, 9:10 PM

	Unknown Object (File)
	Thu, Oct 15, 7:43 PM

	Unknown Object (File)
	Thu, Oct 15, 7:42 PM

	Unknown Object (File)
	Thu, Oct 15, 3:43 AM

	Unknown Object (File)
	Wed, Oct 14, 4:32 PM

	Unknown Object (File)
	Wed, Oct 14, 4:24 PM

View All 22 Files

Subscribers

imp

Details

Reviewers

markj
jhb

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Tue, Oct 13, 3:23 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 13, 3:23 PM

kib requested review of this revision.Tue, Oct 13, 3:23 PM

markj added inline comments.Tue, Oct 13, 3:39 PM

lib/msun/i387/fenv.c
70	This is still referenced in lib/msun/i387/Symbol.map. So presumably the symbol must be kept, and the implementation can always return 1?

Slap one more HAS_SSE()
Restore test_sse and __has_sse.

This passed buildworld.

kib marked an inline comment as done.Tue, Oct 13, 4:05 PM

markj added inline comments.Wed, Oct 14, 6:44 PM

lib/msun/i387/fenv.c
39	__SSE_YES is 0, so this return value is inverted.

Return '1' from __test_sse().

markj accepted this revision.Thu, Oct 15, 7:49 PM

This revision is now accepted and ready to land.Thu, Oct 15, 7:49 PM

Revision Contents
Changeset List

Path

Size

lib/

msun/

i387/

fenv.c

105 lines

x86/

fenv.h

56 lines

Diff 189935

View Options

lib/msun/i387/fenv.c