if_bnxt: fix powerpc build of the MPC ring code
ClosedPublic
Actions

Authored by sumit.saxena_broadcom.com on Tue, Oct 13, 9:19 AM.

Details

Reviewers

gallatin
chandrakanth.patil_broadcom.com
shurd

Commits

rGb43c4d84c8d1: if_bnxt: fix powerpc build of the MPC ring code

Summary

powerpc has no 16-bit acquire/release atomics, so the
atomic_load_acq_16() and atomic_store_rel_16() calls on the MPC TX
ring indices fail to build there. Make the producer and consumer
indices 32 bits wide and use the 32-bit primitives.

Fixes: 088a42c0ff76 ("if_bnxt: add MPC (Mid-Path Channel) ring infrastructure")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sumit.saxena_broadcom.com created this revision.Tue, Oct 13, 9:19 AM

Herald added a reviewer: shurd. · View Herald TranscriptTue, Oct 13, 9:19 AM

sumit.saxena_broadcom.com requested review of this revision.Tue, Oct 13, 9:19 AM

chandrakanth.patil_broadcom.com accepted this revision.Tue, Oct 13, 11:00 AM

This revision is now accepted and ready to land.Tue, Oct 13, 11:00 AM

gallatin accepted this revision.Tue, Oct 13, 1:11 PM

Closed by commit rGb43c4d84c8d1: if_bnxt: fix powerpc build of the MPC ring code (authored by sumit.saxena_broadcom.com). · Explain WhyTue, Oct 13, 2:29 PM

This revision was automatically updated to reflect the committed changes.

sumit.saxena_broadcom.com added a commit: rGb43c4d84c8d1: if_bnxt: fix powerpc build of the MPC ring code.

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 13, 2:29 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bnxt/

bnxt_en/

bnxt.h

4 lines

bnxt_mpc.c

15 lines

Diff 189726

View Options

sys/dev/bnxt/bnxt_en/bnxt.h