Page MenuHomeFreeBSD

Add new ports committer (longros)
Needs ReviewPublic

Authored by chris.longros_gmail.com on Fri, Oct 9, 6:03 AM.

Details

Reviewers
jrm
yuri
Summary

Steps for new committers:

  1. Add myself to authors
  2. Update lists of developers and contributors
  3. Add a news entry
  4. Add my PGP key

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Fri, Oct 9, 8:09 AM

Christos, it looks like you missed a file. In step 4 of https://docs.freebsd.org/en/articles/committers-guide/#conventions-committers, there is a link to a README file. In that file, it says you should also add text to documentation/content/en/articles/pgpkeys/_index.adoc. It looks like @des's addkey.sh script should also mention this. You used the script, right?

This revision now requires review to proceed.Fri, Oct 9, 6:36 PM

This looks good. Could you also verify that you built the documentation/website? A successful build helps confirm that there isn't a little nit we missed.

In D60502#1388517, @jrm wrote:

This looks good. Could you also verify that you built the documentation/website? A successful build helps confirm that there isn't a little nit we missed.

I built the documentation and website. The English build has no warnings. The full build shows only translation warnings

➜  ~ cd ~/freebsd-doc/website
➜  website git:(main) ✔ make
---------------------------------------------------------------
Building the website started on Fri  9 Oct 2026 21:32:19 CEST
 included languages: en ru zh-tw
 excluded languages:
---------------------------------------------------------------
HUGO_DISABLELANGUAGES="" /usr/local/bin/hugo
Start building sites …
hugo v0.167.0+extended freebsd/amd64 BuildDate=2026-09-28T21:13:07Z+0000 VendorInfo=freebsd


                 │  EN  │  RU  │ ZH - TW
─────────────────┼──────┼──────┼─────────
 Pages           │ 1927 │  424 │      34
 Paginator pages │    0 │    0 │       0
 Non-page files  │ 3185 │  200 │       0
 Static files    │ 3972 │ 3972 │    3972
 Processed       │    0 │    0 │       0
 images          │      │      │
 Aliases         │    2 │    1 │       0
 Cleaned         │    0 │    0 │       0

Total in 102132 ms
---------------------------------------------------------------
Building the website completed on Fri  9 Oct 2026 21:34:01 CEST
---------------------------------------------------------------
➜  website git:(main) ✔

➜  documentation git:(main) ✔ make
---------------------------------------------------------------
Building the documentation
included languages: bn-bd da de el en es fr hu id it ja ko mn nl pl pt-br ru tr zh-cn zh-tw
excluded languages:
---------------------------------------------------------------
HUGO_DISABLELANGUAGES="" /usr/local/bin/hugo --minify
Start building sites …
hugo v0.167.0+extended freebsd/amd64 BuildDate=2026-09-28T21:13:07Z+0000 VendorInfo=freebsd

           │      │     │     │     │     │     │     │     │     │     │     │     │      │     │     │     │     │     │     │
───────────┼──────┼─────┼─────┼─────┼─────┼─────┼─────┼─────┼─────┼─────┼─────┼─────┼──────┼─────┼─────┼─────┼─────┼─────┼─────┼─────
 Pages     │ 1266 │ 274 │ 263 │   6 │   5 │ 108 │  61 │  47 │  22 │ 367 │  89 │  53 │ 1264 │   5 │  51 │  71 │  93 │ 210 │  48 │  10
 Paginator │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0
 pages     │      │     │     │     │     │     │     │     │     │     │     │     │      │     │     │     │     │     │     │
 Non-page  │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0
 files     │      │     │     │     │     │     │     │     │     │     │     │     │      │     │     │     │     │     │     │
 Static    │  888 │ 888 │ 888 │ 888 │ 888 │ 888 │ 888 │ 888 │ 888 │ 888 │ 888 │ 888 │  888 │ 888 │ 888 │ 888 │ 888 │ 888 │ 888 │ 888
 files     │      │     │     │     │     │     │     │     │     │     │     │     │      │     │     │     │     │     │     │
 Processed │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0
 images    │      │     │     │     │     │     │     │     │     │     │     │     │      │     │     │     │     │     │     │
 Aliases   │    1 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0
 Cleaned   │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │   0 │    0 │   0 │   0 │   0 │   0 │   0 │   0 │   0

Total in 357906 ms