kyua: Fixes after vendor merge

[igoro]

It seems the recent vendor merge was mostly like an override. This is the set of fixes I identified so far.

I plan to eventually bring them to github/freebsd/kyua to avoid the difference in the future.

[ngie]

Please submit this change upstream so I can integrate them into the next release.
I ran into so many conflicts that I just chose the upstream version of files by default. I want to get out of that habit by getting things to converge again between the copy in the FreeBSD src tree and on GitHub.

[ngie]

contrib/kyua/os/freebsd/main.cpp

62–69

Sidenote: these calls should use std::make_shared(..) instead of std::shared_ptr(..) with new.

[igoro]

In D60446#1386937, @ngie wrote:

Please submit this change upstream so I can integrate them into the next release.
I ran into so many conflicts that I just chose the upstream version of files by default. I want to get out of that habit by getting things to converge again between the copy in the FreeBSD src tree and on GitHub.

Yeah, I expected that merge might face some troubles, and I had in my plans to help you after the merge. That's why I was manually examining the diff between "before" and "after the merge".

I will upstream "kyua prepare" first, and these fixes after, due to the dependencies.

[igoro]

contrib/kyua/os/freebsd/main.cpp

62–69

Sidenote: these calls should use std::make_shared(..) instead of std::shared_ptr(..) with new.

Nice catch, thanks. Migrated to std::make_shared<>().