Differential D60358

tests/libc: use an allowlist for sbrk in NetBSD-derived tests
Needs ReviewPublic
Actions

Authored by zhaoxiaoqiang007_gmail.com on Mon, Oct 5, 4:21 AM.

Tags

None

Referenced Files

	F174825620: D60358.diff
	Tue, Oct 6, 6:15 AM

	F174809062: D60358.id188686.diff
	Tue, Oct 6, 3:21 AM

	F174796835: D60358.diff
	Tue, Oct 6, 1:29 AM

Subscribers

Details

Reviewers

ngie
imp
kib
brooks

Summary

sbrk is obsolete and libc only provides it on amd64, arm, i386 and
powerpc. Replace the growing exclusion lists in t_dir.c and t_mlock.c
with a single positive HAS_SBRK definition per file, so architectures
without sbrk need not be enumerated as they are added.

Signed-off-by: Xiaoqiang Zhao <zhaoxiaoqiang007@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77710
Build 74593: arc lint + arc unit

Event Timeline

zhaoxiaoqiang007_gmail.com created this revision.Mon, Oct 5, 4:21 AM

Herald added a reviewer: ngie. · View Herald TranscriptMon, Oct 5, 4:21 AM

Herald added a subscriber: imp. · View Herald Transcript

zhaoxiaoqiang007_gmail.com requested review of this revision.Mon, Oct 5, 4:21 AM

Harbormaster completed remote builds in B77710: Diff 188686.Mon, Oct 5, 4:21 AM

zhaoxiaoqiang007_gmail.com mentioned this in D59893: libc: add LoongArch support.Mon, Oct 5, 4:28 AM

zhaoxiaoqiang007_gmail.com added a reviewer: imp.Mon, Oct 5, 4:30 AM

zhaoxiaoqiang007_gmail.com added reviewers: kib, brooks.Mon, Oct 5, 4:32 AM

Revision Contents
Changeset List

Path

Size

contrib/

netbsd-tests/

lib/

libc/

gen/

14 lines

sys/

14 lines

Diff 188686

contrib/netbsd-tests/lib/libc/gen/t_dir.c

Loading...

contrib/netbsd-tests/lib/libc/sys/t_mlock.c

Loading...