libpfctl: remove the state getters that do not take a handle

[rcm]

Summary

Nothing in the tree calls any of the three. Remove them rather than
fix them: pfctl_get_states_h() does the same with the handle that the
caller has. pfctl_free_states(), struct pfctl_states and the list
entry in struct pfctl_state were there for pfctl_get_states() alone,
and go with it.

Fixes: 2a478dfc7f9c ("libpfctl: retrieve family id only once")
Sponsored by: Rubicon Communications, LLC ("Netgate")

Test Plan

No functional change intended.

[kp]

I wonder if we shouldn't just remove these versions of the get_states functions altogether.

This version is unhelpful because it doesn't take the pfctl_handle. There's a _h variant which does, and which should get used instead.

[rcm]

In D60248#1382592, @kp wrote:

I wonder if we shouldn't just remove these versions of the get_states functions altogether.

This version is unhelpful because it doesn't take the pfctl_handle. There's a _h variant which does, and which should get used instead.

Yes let's do that. The one out-of-tree caller I know of is the pfSense PHP module, which I'll move to pfctl_get_states_h.

[rcm]

pivoted to just removing these getters entirely