elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree
ClosedPublic
Actions

Authored by emaste on Apr 19 2016, 1:13 PM.

Details

Reviewers

ngie
bdrewery

Commits

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

emaste retitled this revision from to elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: ngie, bdrewery.

lib/libdwarf/Makefile
5 ↗	(On Diff #15315)	Also renamed `TOP` to `ELFTCDIR` as used elsewhere in ELF Tool Chain build bits to avoid confusion.

ngie edited edge metadata.

ngie added inline comments.

This revision is now accepted and ready to land.Apr 20 2016, 12:06 AM

lib/libdwarf/Makefile
5 ↗	(On Diff #15315)	Unfortunately `ELFTCDIR` is too long and it looks odd with a tab after, unless `SRCDIR` below gets indented an extra tab, and then PACKAGE= looks out of place: PACKAGE=lib${LIB} ELFTCDIR= ${SRCTOP}/contrib/elftoolchain SRCDIR= ${ELFTCDIR}/libdwarf
lib/libelf/Makefile
83 ↗	(On Diff #15315)	It's needed for `< >` includes relative to `.`.