Page MenuHomeFreeBSD
Differential D59588

chflags: Alias nocache to noucache for consistency
AcceptedPublic
Actions

Authored by ziaee on Fri, Sep 11, 12:14 PM.
Tags
None
Referenced Files
F171681840: D59588.id186457.diff
Sat, Sep 12, 4:09 PM
F171681663: D59588.diff
Sat, Sep 12, 4:06 PM
Unknown Object (File)
Fri, Sep 11, 1:01 PM
Subscribers
imp

Details

Reviewers
fuz
rmacklem
Summary

Requested by: fuz

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76771
Build 73654: arc lint + arc unit

Event Timeline

ziaee created this revision.Fri, Sep 11, 12:14 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 11, 12:14 PM
ziaee requested review of this revision.Fri, Sep 11, 12:14 PM
Harbormaster completed remote builds in B76771: Diff 186457.Fri, Sep 11, 12:14 PM
fuz added inline comments.Fri, Sep 11, 1:10 PM
lib/libc/gen/strtofflags.c
84–90

Try this, should build fine and avoids the duplicated nousystem line.

rmacklem accepted this revision.Fri, Sep 11, 1:39 PM
rmacklem added inline comments.
lib/libc/gen/strtofflags.c
84–90

You can do so, but I did it the way I did it
to maintain a consistent style. style(9) says
that style should only be changed for major
re-writes.

But choose whichever way you prefer.

This revision is now accepted and ready to land.Fri, Sep 11, 1:39 PM
fuz accepted this revision.Fri, Sep 11, 2:14 PM

Accepted subject to the changes I have proposed.

lib/libc/gen/strtofflags.c
84–90

It's not really a style change. More of a simplification of lines that'll be touched anyway.

Revision Contents
Changeset List

PathSize
bin/
chflags/
2 lines
lib/
libc/
gen/
1 line

Diff 186457

View Options

bin/chflags/chflags.1

Loading...
View Options

lib/libc/gen/strtofflags.c

Loading...