Daemon that starts conky and rotates the desktop wallpaper. Detects
fvwm, bvwm, GNOME, and KDE, and sets wallpaper with hsetroot(1).
Sample conky rcs, wallpapers, and configuration overlay included.
Details
Details
- Reviewers
jrm fuz - Commits
- R11:5d76c03ec9fe: sysutils/condy: Add new port
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thank you for your submission.
It would be great to have the configuration files in ${PREFIX}/etc as per the usual conventions. You can use REINPLACE_CMD in a custom do-configure target to do so.
A github WWW is automatically set if WWW is unset and USE_GITHUB is enabled, so you can remove your own setting.
The theme config files mentioned in the script seem to not be present in the repository, is this correct?
Apart from these, the port looks good!
Comment Actions
Could you rebase onto a recent main?
% git arc patch -bcs D59509
Switched to a new branch 'gitarc-D59509'
Applying D59509...
Checking patch sysutils/condy/pkg-descr...
Checking patch sysutils/condy/distinfo...
Checking patch sysutils/condy/Makefile...
Checking patch sysutils/Makefile...
error: while searching for:
SUBDIR += cmospwd
SUBDIR += colorize
SUBDIR += conan
SUBDIR += confctl
SUBDIR += conky
SUBDIR += conky-awesome
error: patch failed: sysutils/Makefile:223
Applied patch sysutils/condy/pkg-descr cleanly.
Applied patch sysutils/condy/distinfo cleanly.
Applied patch sysutils/condy/Makefile cleanly.
Applying patch sysutils/Makefile with 1 reject...
Rejected hunk #1.
Patch Failed!
Usage Exception: Unable to apply patch!Comment Actions
Works now:
dteske@FreeBSD ports $ git arc patch -cs D59509 Applying D59509... Checking patch sysutils/condy/pkg-descr... Checking patch sysutils/condy/distinfo... Checking patch sysutils/condy/Makefile... Checking patch sysutils/Makefile... Applied patch sysutils/condy/pkg-descr cleanly. Applied patch sysutils/condy/distinfo cleanly. Applied patch sysutils/condy/Makefile cleanly. Applied patch sysutils/Makefile cleanly. APPLIED Successfully applied patch. [gitarc-D59509 759271f54ed6] sysutils/condy: Add new port 4 files changed, 32 insertions(+) create mode 100644 sysutils/condy/Makefile create mode 100644 sysutils/condy/distinfo create mode 100644 sysutils/condy/pkg-descr
Comment Actions
LGTM and approved for commit.
Consider patching the script so that it places its configuration files in ${PREFIX}/etc in the future. Perhaps also supply a sample configuration file (see @sample in Porter's Handbook).
Comment Actions
Looks good to me.
Approved for commit.
| sysutils/condy/Makefile | ||
|---|---|---|
| 26 | DOCS and EXAMPLES are always on by default and do not need to be set explicitly. | |