Page MenuHomeFreeBSD

bectl: stop pretending that jailparam_delarg can fail
AcceptedPublic

Authored by kevans on Sep 5 2026, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 6, 5:05 AM
Unknown Object (File)
Tue, Oct 6, 4:15 AM
Unknown Object (File)
Thu, Oct 1, 3:27 AM
Unknown Object (File)
Wed, Sep 30, 8:05 PM
Unknown Object (File)
Sun, Sep 27, 6:35 AM
Unknown Object (File)
Sat, Sep 26, 9:31 PM
Unknown Object (File)
Fri, Sep 25, 12:38 PM
Unknown Object (File)
Thu, Sep 24, 6:32 PM
Subscribers

Details

Reviewers
ngie
rew
Summary

Its only failure mode was name == NULL, but we only ever pass in
optarg from a required-argument flag. Drop the pretense and convert
that conditional to an assertion, because it's actually actively
harmful: GCC 14, at least, will deduce that the error path means that
optarg can be NULL and raise a warning about passing NULL to an %s
specifier.

PR: 298192

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76560
Build 73443: arc lint + arc unit