Page MenuHomeFreeBSD

bmake: use longer and more unique tempfile names
AbandonedPublic

Authored by wosch on Fri, Sep 4, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 28, 11:29 AM
Unknown Object (File)
Sun, Sep 27, 7:52 PM
Unknown Object (File)
Sat, Sep 26, 12:27 PM
Unknown Object (File)
Wed, Sep 23, 2:18 PM
Unknown Object (File)
Wed, Sep 23, 1:58 PM
Unknown Object (File)
Mon, Sep 21, 10:40 PM
Unknown Object (File)
Thu, Sep 17, 12:11 AM
Unknown Object (File)
Sat, Sep 12, 10:33 PM
Subscribers

Details

Reviewers
sjg
Summary

Temporary file names should have at least 10 random characters.

6 X are not enough.

Maybe this needs to be reported upstream as well.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wosch requested review of this revision.Fri, Sep 4, 7:40 PM

Yes, this should be addressed in upstream

contrib/bmake/configure
8072

This is generated by autoconf - don't mess with it

Q why 10 ? mktemp(1) on netbsd uses 8 in its examples, mktemp(1) on freebsd uses 6

In D59424#1373884, @sjg wrote:

Q why 10 ? mktemp(1) on netbsd uses 8 in its examples, mktemp(1) on freebsd uses 6

10 X seems to be consensus among most modern supported OS

Debian12/13, FreeBSD 14/stable, 15/stable, 16-current uses 10 X by default:
$ mktemp | perl -npe 's/.+\.//; chomp' | wc -c
10

According to its man page, OpenBSD has also used 10X for a very long time.

FYI this has been addressed in NetBSD, will be in the next import

In D59424#1375090, @sjg wrote:

FYI this has been addressed in NetBSD, will be in the next import

Many thanks!