Page MenuHomeFreeBSD
Differential D59351

libcasper: use PD_NOWAITPID to avoid zombies in consumers
AbandonedPublic
Actions

Authored by bapt on Thu, Sep 3, 6:39 PM.
Tags
None
Referenced Files
F170579991: D59351.id.diff
Sat, Sep 5, 12:14 PM
F170576802: D59351.id185734.diff
Sat, Sep 5, 11:52 AM
F170495462: D59351.id185734.diff
Sat, Sep 5, 2:32 AM
F170494618: D59351.diff
Sat, Sep 5, 2:26 AM
Unknown Object (File)
Fri, Sep 4, 7:02 PM
Unknown Object (File)
Fri, Sep 4, 2:51 AM
Unknown Object (File)
Thu, Sep 3, 10:35 PM
Unknown Object (File)
Thu, Sep 3, 9:38 PM
View All 10 Files
Subscribers
imp

Details

Reviewers
kib
markj
Summary

libcasper is never calling waitpid on the resulting pid of pdfork()
which results on its consumers into the creation of zombies since
bcdb6ba94d08.

This fixes rtsold which is always leaving a zombies since bcdb6ba94d08
landed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76435
Build 73318: arc lint + arc unit

Event Timeline

bapt created this revision.Thu, Sep 3, 6:39 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 3, 6:39 PM
bapt requested review of this revision.Thu, Sep 3, 6:39 PM
Harbormaster completed remote builds in B76435: Diff 185734.Thu, Sep 3, 6:39 PM
bapt added reviewers: kib, markj.Thu, Sep 3, 6:40 PM

Note There is another pdfork() which we don't have anycall on waitpid either in zygote.c, but those are long living processes which dies along with the main process and so get reaped normally. so I haven't added the flag on it.

bapt mentioned this in D59323: rtsold: ignore SIGCHLD to reap the casper daemon.Thu, Sep 3, 6:42 PM
bapt abandoned this revision.Thu, Sep 3, 6:47 PM

https://reviews.freebsd.org/D59348

Revision Contents
Changeset List

PathSize
lib/
libcasper/
libcasper/
2 lines

Diff 185734

View Options

lib/libcasper/libcasper/libcasper.c

Loading...