Page MenuHomeFreeBSD

arm/ti: correct softc member name in ti_mux_clock and ti_gate_clock
Needs ReviewPublic

Authored by rick_sloservers.com on Aug 23 2026, 8:06 AM.
Tags
Referenced Files
F176092234: D59119.diff
Fri, Oct 16, 1:11 AM
Unknown Object (File)
Sun, Oct 11, 11:22 PM
Unknown Object (File)
Sun, Oct 11, 6:40 AM
Unknown Object (File)
Sat, Oct 10, 9:08 AM
Unknown Object (File)
Tue, Oct 6, 6:43 PM
Unknown Object (File)
Mon, Oct 5, 12:27 PM
Unknown Object (File)
Thu, Oct 1, 7:48 AM
Unknown Object (File)
Thu, Sep 24, 10:53 PM
Subscribers
None

Details

Reviewers
imp
andrew
manu
oh
Summary

18250ec6c089 ("Replace calls to bus_generic_attach with
bus_attach_children") changed three calls in each of ti_mux_clock.c and
ti_gate_clock.c to bus_attach_children(sc->dev), but these softcs name
the member sc_dev, so neither file compiles. Nothing caught it because
no kernel config in the tree builds these files since AM335x was
removed from armv7 GENERIC in 3416e102c4e9.

Use sc->sc_dev, as the neighbouring lines already do.

Test Plan

As with D59118, compile coverage requires an AM335x kernel configuration
(see D46703).

Verified by building KERNCONF=AM335X for TARGET=arm TARGET_ARCH=armv7 on
stable/15: the files compile, and the resulting kernel boots to multi-user
on a BeagleBone Black Rev B3 with the TI clock tree registering (mux,
gate, divider and DPLL nodes all attach).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped