Page MenuHomeFreeBSD

tarfs_test: split large file test into independent cases
Needs ReviewPublic

Authored by siva on Thu, Aug 20, 7:24 AM.
Tags
None
Referenced Files
F168382548: D59033.diff
Thu, Aug 27, 9:51 PM
F168336694: D59033.diff
Thu, Aug 27, 4:31 PM
F168333459: D59033.diff
Thu, Aug 27, 4:11 PM
Unknown Object (File)
Wed, Aug 26, 7:58 AM
Unknown Object (File)
Tue, Aug 25, 9:01 PM
Unknown Object (File)
Tue, Aug 25, 10:10 AM
Unknown Object (File)
Sun, Aug 23, 9:57 PM
Unknown Object (File)
Sun, Aug 23, 9:15 PM
Subscribers

Details

Reviewers
des
stevek
Summary

This avoids globally set timeouts for the group of
tarfs_large tests on slower emulated architectures.

While here, lower each testcase's timeout to reflect
the reduction of work. On QEMU aarch64, the largest case
runs in ~500s on a modern desktop, so double that for a
conservative estimate.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75778
Build 72661: arc lint + arc unit

Event Timeline

siva requested review of this revision.Thu, Aug 20, 7:24 AM

Generating tests at run time (and especially generating them from atf_init_test_cases()) is problematic because the script gets run more than once per test case, so we keep generating code over and over even when we don't need it. I would prefer multiple thin hand-written wrappers around tarfs_large_test().