Page MenuHomeFreeBSD

Update if_rt to support more SoCs via both FDT and non-FDT
ClosedPublic

Authored by sgalabov on Apr 6 2016, 3:04 PM.

Details

Summary

This revision adds support to if_rt for more SoCs.

The SoCs I've tried the driver with include the following:
RT3050, RT5350, RT3662, RT3883, MT7620, MT7621, MT7688.
On boards, based on the above SoCs traffic is passing through correctly and the boards survive a flood ping with very little or no drops (drops may be caused elsewhere in my test setup, however).

One issue still remains and needs to be fixed in the future: if_rt does not survive an ifconfig rt0 down/ifconfig rt0 up cycle.
This issue existed before this commit as well, however.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sgalabov updated this revision to Diff 14933.Apr 6 2016, 3:04 PM
sgalabov retitled this revision from to Update if_rt to support more SoCs via both FDT and non-FDT.
sgalabov updated this object.
sgalabov edited the test plan for this revision. (Show Details)
sgalabov added reviewers: adrian, ray.
sgalabov set the repository for this revision to rS FreeBSD src repository.
adrian accepted this revision.Apr 6 2016, 4:28 PM
adrian edited edge metadata.
adrian added inline comments.
sys/dev/rt/if_rt.c
384 ↗(On Diff #14933)

We should document these RX descriptor bit fields in a header file and include those definitions here.

This revision is now accepted and ready to land.Apr 6 2016, 4:28 PM
sgalabov added inline comments.Apr 6 2016, 5:38 PM
sys/dev/rt/if_rt.c
384 ↗(On Diff #14933)

Oops, this escaped me somehow... I can do this before committing if you don't mind?

adrian added a comment.Apr 6 2016, 5:41 PM

Sure thing, go ahead.

ray accepted this revision.Apr 6 2016, 6:52 PM
ray edited edge metadata.

Looks good to me too. Thanks Stanislav.

This revision was automatically updated to reflect the committed changes.