Page MenuHomeFreeBSD
Differential D58450

brcmfmac: reformat FreeBSD vs Linux line
Needs ReviewPublic
Actions

Authored by ngie on Jul 24 2026, 10:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 10, 10:54 PM
Unknown Object (File)
Sun, Aug 9, 10:23 PM
Unknown Object (File)
Sat, Aug 8, 4:50 PM
Unknown Object (File)
Sat, Aug 8, 10:52 AM
Unknown Object (File)
Fri, Aug 7, 9:11 PM
Unknown Object (File)
Tue, Aug 4, 9:27 PM
Unknown Object (File)
Mon, Aug 3, 8:35 PM
Unknown Object (File)
Sun, Aug 2, 3:39 AM
View All 19 Files
Subscribers
adrian
imp

Details

Reviewers
bz
Summary

Move the last argument to into the respective conditional.

This makes rudimentary editors (like neovim) happier when evaluating
statement correctness.

Test Plan

neovim loves me again after this change!

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75111
Build 71994: arc lint + arc unit

Event Timeline

ngie created this revision.Jul 24 2026, 10:59 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 24 2026, 10:59 PM
ngie requested review of this revision.Jul 24 2026, 10:59 PM
Harbormaster completed remote builds in B75111: Diff 182653.Jul 24 2026, 10:59 PM
ngie edited the test plan for this revision. (Show Details)Jul 24 2026, 11:00 PM
ngie added a reviewer: bz.
ngie added a subscriber: adrian.
bz added a comment.Jul 25 2026, 11:40 AM

I would say "NO". The idea is to keep the #ifdef portion minimal as most of the differences will have to be upstreamed one day. Keeping the #ifdef away from the next statement makes merging easier.

Revision Contents
Changeset List

PathSize
sys/
contrib/
dev/
broadcom/
brcm80211/
brcmfmac/
3 lines

Diff 182653

View Options

sys/contrib/dev/broadcom/brcm80211/brcmfmac/pcie.c

Loading...