brcmfmac: reformat FreeBSD vs Linux line
Needs ReviewPublic
Actions

Authored by ngie on Fri, Jul 24, 10:59 PM.

Tags

None

Referenced Files

	F164767655: D58450.diff
	Mon, Aug 3, 8:35 PM

	Unknown Object (File)
	Sun, Aug 2, 3:39 AM

	Unknown Object (File)
	Sat, Aug 1, 6:38 AM

	Unknown Object (File)
	Fri, Jul 31, 1:13 PM

	Unknown Object (File)
	Fri, Jul 31, 4:19 AM

	Unknown Object (File)
	Thu, Jul 30, 7:23 AM

	Unknown Object (File)
	Wed, Jul 29, 4:56 PM

	Unknown Object (File)
	Wed, Jul 29, 4:04 AM

View All 13 Files

Subscribers

adrian

imp

Details

Reviewers

Summary

Move the last argument to into the respective conditional.

This makes rudimentary editors (like neovim) happier when evaluating
statement correctness.

Test Plan

neovim loves me again after this change!

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75111
Build 71994: arc lint + arc unit

Event Timeline

ngie created this revision.Fri, Jul 24, 10:59 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jul 24, 10:59 PM

ngie requested review of this revision.Fri, Jul 24, 10:59 PM

Harbormaster completed remote builds in B75111: Diff 182653.Fri, Jul 24, 10:59 PM

ngie edited the test plan for this revision. (Show Details)Fri, Jul 24, 11:00 PM

ngie added a reviewer: bz.

ngie added a subscriber: adrian.

I would say "NO". The idea is to keep the #ifdef portion minimal as most of the differences will have to be upstreamed one day. Keeping the #ifdef away from the next statement makes merging easier.

Revision Contents
Changeset List

Path

Size

sys/

contrib/

dev/

broadcom/

brcm80211/

brcmfmac/

pcie.c

3 lines

Diff 182653

View Options

sys/contrib/dev/broadcom/brcm80211/brcmfmac/pcie.c

brcmfmac: reformat FreeBSD vs Linux lineNeeds ReviewPublicActions