Page MenuHomeFreeBSD

bsd.clang-analyze.mk: silence Annex K (DeprecatedOrUnsafeBufferHandling) by default
Needs ReviewPublic

Authored by siva on Fri, Jul 24, 5:49 PM.

Details

Reviewers
None
Group Reviewers
srcmgr
Summary

This introduces a new make variable CLANG_ANALYZE_SILENCED_CHECKERS that
silences a given list of checkers (from https://clang.llvm.org/docs/analyzer/checkers.html).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75099
Build 71982: arc lint + arc unit

Event Timeline

siva requested review of this revision.Fri, Jul 24, 5:49 PM
markj added inline comments.
share/mk/bsd.clang-analyze.mk
47

I think some comment explaining why we suppress this would be worthwhile.

Also this feels like too large a hammer. This flag also suppresses warnings about use of sprintf()... but that's quite different from fprintf(). That's really silly. :(

And to top it off, we don't even implement fprintf_s() or sprintf_s() as far as I can see.