pseudofs: Don't purge the cache on shutdown
AcceptedPublic
Actions

Authored by des on Mon, Jul 20, 6:46 PM.

Tags

None

Referenced Files

	F164749458: D58359.id.diff
	Mon, Aug 3, 3:29 PM

	Unknown Object (File)
	Sun, Aug 2, 9:28 PM

	Unknown Object (File)
	Sat, Aug 1, 6:04 AM

	Unknown Object (File)
	Fri, Jul 31, 1:31 AM

	Unknown Object (File)
	Wed, Jul 29, 3:18 PM

	Unknown Object (File)
	Mon, Jul 27, 1:34 PM

	Unknown Object (File)
	Mon, Jul 27, 12:41 PM

	Unknown Object (File)
	Mon, Jul 27, 10:35 AM

View All 16 Files

Subscribers

imp

Details

Reviewers

glebius

Summary

This is a waste of time and results in a use-after-free if linsysfs is
loaded and a USB network interface is in use, since USB devices are
disconnected at shutdown, which triggers a call into linsysfs, which
then tries to destroy a pseudofs node which has already been purged.

MFC after: 1 week
Reported by: glebius

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74961
Build 71844: arc lint + arc unit

Event Timeline

des created this revision.Mon, Jul 20, 6:46 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 20, 6:46 PM

des requested review of this revision.Mon, Jul 20, 6:46 PM

Harbormaster completed remote builds in B74961: Diff 182300.Mon, Jul 20, 6:46 PM

Thanks! While I'm 99% sure it is going to fix my panic, I can't test it right away. Traveling right now and machine that exhibits it is not with me. I'll be able to test next week. If you want you can delay the push until I test. I will report here, in this revision.

This revision is now accepted and ready to land.Mon, Jul 20, 6:59 PM

@glebius have you been able to test?

I will be able tomorrow. Was traveling this week. Will update.

Revision Contents
Changeset List

Path

Size

sys/

fs/

pseudofs/

pseudofs.c

1 line

Diff 182300

View Options

sys/fs/pseudofs/pseudofs.c

pseudofs: Don't purge the cache on shutdownAcceptedPublicActions