Page MenuHomeFreeBSD

rockchip: fix stack overflow in rk8xx_rtc
ClosedPublic

Authored by kevans on Sun, Jul 12, 1:17 AM.
Tags
None
Referenced Files
F162585402: D58182.id181809.diff
Tue, Jul 14, 7:27 PM
F162584126: D58182.id181836.diff
Tue, Jul 14, 7:08 PM
Unknown Object (File)
Mon, Jul 13, 5:19 PM
Unknown Object (File)
Sun, Jul 12, 6:34 PM
Unknown Object (File)
Sun, Jul 12, 5:07 AM
Unknown Object (File)
Sun, Jul 12, 4:46 AM
Unknown Object (File)
Sun, Jul 12, 3:19 AM
Unknown Object (File)
Sun, Jul 12, 1:21 AM
Subscribers

Details

Summary

Presumably surfaced by -fstack-protector-strong, rk8xx_settime was
triggering SSP when ntpd set the time on the RockPro64, at the very
least. A minor oops meant that the weeks mask was getting tossed into
the wrong field, and the mask was never populated. The mask is 0x7 for
all three of these, thus overflowing the data array in settime by one
byte.

Reported by: jsm, "Tenkawa" on Discord

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable