Page MenuHomeFreeBSD
Differential D58065

sched_4bsd: rename runq to runq_global
Needs ReviewPublic
Actions

Authored by minsoochoo0122_proton.me on Mon, Jul 6, 10:24 PM.
Tags
None
Referenced Files
F162204294: D58065.diff
Fri, Jul 10, 9:12 PM
F162201494: D58065.diff
Fri, Jul 10, 8:37 PM
F162197704: D58065.id181468.diff
Fri, Jul 10, 7:48 PM
F162182896: D58065.diff
Fri, Jul 10, 4:14 PM
Unknown Object (File)
Thu, Jul 9, 9:23 AM
Subscribers
imp
olce

Details

Reviewers
olce
Summary

In upcoming changes, 'struct td_sched' will store CPU ID of the thread's
current runqueue instead of a pointer to the runqueue. This requires
functions to store pointer to the runqueue as a local variable. Although
the name 'runq' seams ideal for these local variables, it is already
taken by the global runqueue. Thus rename the global runqueue to
'runq_global' to hint the variable is the global runqueue and yield the
name 'runq' to local variables.

Suggested by: olce

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74594
Build 71477: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Mon, Jul 6, 10:24 PM
Herald added subscribers: olce, imp. · View Herald TranscriptMon, Jul 6, 10:24 PM
minsoochoo0122_proton.me requested review of this revision.Mon, Jul 6, 10:24 PM
Harbormaster completed remote builds in B74559: Diff 181387.Mon, Jul 6, 10:24 PM
minsoochoo0122_proton.me added a reviewer: olce.Mon, Jul 6, 10:25 PM
minsoochoo0122_proton.me added a child revision: D58000: sched_4bsd: use DPCPU for runq.
olce accepted this revision.Tue, Jul 7, 2:45 PM

Looks much better like that. :-) "Suggested by: olce" appreciated.

Do you want me to commit that? Or can you with jhb@'s approval?

This revision is now accepted and ready to land.Tue, Jul 7, 2:45 PM
minsoochoo0122_proton.me updated this revision to Diff 181468.Tue, Jul 7, 5:44 PM

Add Suggested by: olce

This revision now requires review to proceed.Tue, Jul 7, 5:44 PM
Harbormaster completed remote builds in B74594: Diff 181468.Tue, Jul 7, 5:44 PM
minsoochoo0122_proton.me edited the summary of this revision. (Show Details)Tue, Jul 7, 5:44 PM
In D58065#1331883, @olce wrote:

Do you want me to commit that? Or can you with jhb@'s approval?

Since I don't have commit bit yet, could you push it for me? Thanks:)

olce added a comment.Tue, Jul 7, 8:31 PM
In D58065#1332040, @minsoochoo0122_proton.me wrote:

Since I don't have commit bit yet, could you push it for me? Thanks:)

Sure. With the minsoo.io address I presume? Also, did you do some smoke test with this change (it is low risk, but still...)? I'll probably do some tomorrow before committing.

minsoochoo0122_proton.me added a comment.Tue, Jul 7, 8:49 PM
In D58065#1332142, @olce wrote:
In D58065#1332040, @minsoochoo0122_proton.me wrote:

Since I don't have commit bit yet, could you push it for me? Thanks:)

Sure. With the minsoo.io address I presume?

Yes.

Also, did you do some smoke test with this change (it is low risk, but still...)? I'll probably do some tomorrow before committing.

My computer successfully booted and I can login with this patch and the D58000, but I haven't run any test suite. I would appreciate you a lot if you can do that for me.

Revision Contents
Changeset List

PathSize
sys/
kern/
32 lines

Diff 181468

View Options

sys/kern/sched_4bsd.c

Loading...