sched_4bsd: rename runq to runq_global
ClosedPublic
Actions

Authored by mchoo on Mon, Jul 6, 10:24 PM.

Details

Reviewers

olce

Commits

rG26ef66653448: sched_4bsd: Rename the global runqueue

Summary

In upcoming changes, 'struct td_sched' will store CPU ID of the thread's
current runqueue instead of a pointer to the runqueue. This requires
functions to store pointer to the runqueue as a local variable. Although
the name 'runq' seams ideal for these local variables, it is already
taken by the global runqueue. Thus rename the global runqueue to
'runq_global' to hint the variable is the global runqueue and yield the
name 'runq' to local variables.

Suggested by: olce

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mchoo created this revision.Mon, Jul 6, 10:24 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, Jul 6, 10:24 PM

mchoo requested review of this revision.Mon, Jul 6, 10:24 PM

Harbormaster completed remote builds in B74559: Diff 181387.Mon, Jul 6, 10:24 PM

mchoo added a reviewer: olce.Mon, Jul 6, 10:25 PM

mchoo added a child revision: D58000: sched_4bsd: use DPCPU for runq.

Looks much better like that. :-) "Suggested by: olce" appreciated.

Do you want me to commit that? Or can you with jhb@'s approval?

This revision is now accepted and ready to land.Tue, Jul 7, 2:45 PM

Add Suggested by: olce

This revision now requires review to proceed.Tue, Jul 7, 5:44 PM

Harbormaster completed remote builds in B74594: Diff 181468.Tue, Jul 7, 5:44 PM

In D58065#1331883, @olce wrote:

Do you want me to commit that? Or can you with jhb@'s approval?

Since I don't have commit bit yet, could you push it for me? Thanks:)

In D58065#1332040, @minsoochoo0122_proton.me wrote:

Since I don't have commit bit yet, could you push it for me? Thanks:)

Sure. With the minsoo.io address I presume? Also, did you do some smoke test with this change (it is low risk, but still...)? I'll probably do some tomorrow before committing.

In D58065#1332142, @olce wrote:

In D58065#1332040, @minsoochoo0122_proton.me wrote:

Since I don't have commit bit yet, could you push it for me? Thanks:)

Sure. With the minsoo.io address I presume?

Yes.

Also, did you do some smoke test with this change (it is low risk, but still...)? I'll probably do some tomorrow before committing.

My computer successfully booted and I can login with this patch and the D58000, but I haven't run any test suite. I would appreciate you a lot if you can do that for me.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jul 21, 2:27 AM

Closed by commit rG26ef66653448: sched_4bsd: Rename the global runqueue (authored by Minsoo Choo <minsoo@minsoo.io>, committed by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG26ef66653448: sched_4bsd: Rename the global runqueue.