OFED: Add generic function to extract IB speed from netdev
Needs ReviewPublic
Actions

Authored by jhb on Mon, Jun 29, 6:58 PM.

Details

Reviewers

kgalazka
sumit.saxena_broadcom.com
kib
slavash
aehrenberg_nvidia.com

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

Obtained from: Linux commit d41861942fc55c14b6280d9568a0d0112037f065
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74389
Build 71272: arc lint + arc unit

Event Timeline

jhb created this revision.Mon, Jun 29, 6:58 PM

Owners added a reviewer: Restricted Owners Package.Mon, Jun 29, 6:58 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 29, 6:58 PM

jhb requested review of this revision.Mon, Jun 29, 6:58 PM

Harbormaster completed remote builds in B74389: Diff 180941.Mon, Jun 29, 6:58 PM

jhb added reviewers: kgalazka, sumit.saxena_broadcom.com.Mon, Jun 29, 7:00 PM

The upstream Linux commit changed bnxt_re(4) to also use this, but the current code in bnxt_re(4) assumes it has access to a count of lanes, and we don't currently have a way to get that from an ifp. If we add something like that in the future (if_getlanes() or something), then we can backport the commit that added the internal function ib_get_width_and_speed that takes lanes into account. Alternatively, I could backport that commit as well but expose the static function so that bnxt_re(4) could use it directly?

jhb added a reviewer: kib.Tue, Jun 30, 1:57 PM

kib accepted this revision.Tue, Jun 30, 10:43 PM

kib added reviewers: slavash, aehrenberg_nvidia.com.