Page MenuHomeFreeBSD

cpu: New cpu_get_pcpuid(), retrieves internal CPU ID
ClosedPublic

Authored by olce on Sat, Jun 27, 1:44 AM.
Tags
None
Referenced Files
F163407927: D57897.id180801.diff
Wed, Jul 22, 10:56 PM
Unknown Object (File)
Tue, Jul 21, 7:58 PM
Unknown Object (File)
Wed, Jul 15, 11:56 AM
Unknown Object (File)
Wed, Jul 15, 7:28 AM
Unknown Object (File)
Wed, Jul 15, 7:28 AM
Unknown Object (File)
Wed, Jul 15, 5:08 AM
Unknown Object (File)
Thu, Jul 9, 4:01 AM
Unknown Object (File)
Tue, Jul 7, 8:19 PM
Subscribers

Details

Summary

It is a handy shortcut that will be used extensively in
hwpstate_intel(4) and hwpstate_amd(4).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Sat, Jun 27, 1:44 AM
jhb added inline comments.
sys/sys/cpu.h
45

This can now use __BUS_ACCESSOR_DEFAULT() to return NULL by default, which will also mean you can start using cpu_has_pcpu in the pstate drivers to check for the ivar being valid vs manually calling BUS_READ_IVAR. It wouldn't be a functional change, just a cosmetic change that spells things more typically. (Unrelated to this commit, just a nice cleanup you can do as a separate commit)

65

This can also now use __BUS_ACCESSOR_DEFAULT() with a default value of -1.

This revision is now accepted and ready to land.Fri, Jul 3, 3:06 PM

Thanks, will do some followup next week.