bus_macro.sh: Small fixes
Needs ReviewPublic
Actions

Authored by thebugfixers_pm.me on Fri, Jun 26, 11:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 6, 11:42 PM

	Unknown Object (File)
	Sun, Jul 5, 9:44 PM

	Unknown Object (File)
	Thu, Jul 2, 11:56 PM

	Unknown Object (File)
	Mon, Jun 29, 3:20 PM

	Unknown Object (File)
	Mon, Jun 29, 6:31 AM

	Unknown Object (File)
	Mon, Jun 29, 6:08 AM

	Unknown Object (File)
	Sun, Jun 28, 4:44 PM

Subscribers

imp

Details

Reviewers

None

Group Reviewers

Src Committers
Contributor Reviews (src)

Summary

Main change:
collapse the single-iteration loop, keep the explanatory comment

Also:
Replace comments with a TODO equivalent
In POSIX sh, echo flags are undefined.
Double quote to prevent globbing and word splitting.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Fri, Jun 26, 11:53 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 26, 11:53 AM

thebugfixers_pm.me requested review of this revision.Fri, Jun 26, 11:53 AM

thebugfixers_pm.me added a parent revision: D57870: sys/tools/gdb/selftest.sh: Small fixes.Fri, Jun 26, 6:41 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

tools/

bus_macro.sh

35 lines

Diff 180699

View Options

sys/dev/bhnd/tools/bus_macro.sh

sys/dev/bhnd/tools/bus_macro.sh: Small fixesNeeds ReviewPublicActions