make_dtbh.sh: small fixes
Needs ReviewPublic
Actions

Authored by thebugfixers_pm.me on Fri, Jun 26, 10:53 AM.

Details

Reviewers

None

Group Reviewers

Src Committers
Contributor Reviews (src)

Summary

Cleaned up the '#define FDT_DTB_FILE "'${dtb_base_name}.dtb'"' construct

Also:
Use $(...) notation instead of legacy backticks
Double quote to prevent globbing and word splitting

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Fri, Jun 26, 10:53 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 26, 10:53 AM

N.B. I think Phabricator truncated the diff here. This is what I pasted into the box:

diff --git a/sys/tools/fdt/make_dtbh.sh b/sys/tools/fdt/make_dtbh.sh
index 300d93f7a..2435e416e 100755
--- a/sys/tools/fdt/make_dtbh.sh
+++ b/sys/tools/fdt/make_dtbh.sh
@@ -1,7 +1,6 @@
 #!/bin/sh
-#

 # Script generates a $2/fdt_static_dtb.h file.

-dtb_base_name=`basename $1 .dts`
-echo '#define FDT_DTB_FILE "'${dtb_base_name}.dtb'"' > $2/fdt_static_dtb.h
+dtb_base_name=$(basename "$1" .dts)
+echo "#define FDT_DTB_FILE \"${dtb_base_name}.dtb\"" > "${2}/fdt_static_dtb.h"

thebugfixers_pm.me added a parent revision: D57870: sys/tools/gdb/selftest.sh: Small fixes.Fri, Jun 26, 6:41 PM

Revision Contents
Changeset List

Path

Size

sys/

tools/

fdt/

make_dtbh.sh

5 lines

Diff 180690

View Options

sys/tools/fdt/make_dtbh.sh

sys/tools/fdt/make_dtbh.sh: small fixesNeeds ReviewPublicActions