Page MenuHomeFreeBSD

sys/tools/fdt/make_dtb.sh: small fixes
Needs ReviewPublic

Authored by thebugfixers_pm.me on Fri, Jun 26, 10:32 AM.
Tags
None
Referenced Files
F160970988: D57871.id180687.diff
Mon, Jun 29, 12:37 PM
F160936942: D57871.diff
Mon, Jun 29, 6:06 AM
F160935252: D57871.id180687.diff
Mon, Jun 29, 5:39 AM
F160912637: D57871.diff
Sun, Jun 28, 11:57 PM
Unknown Object (File)
Sun, Jun 28, 8:06 PM
Unknown Object (File)
Fri, Jun 26, 5:29 PM
Subscribers

Details

Reviewers
None
Group Reviewers
Src Committers
Contributor Reviews (src)
Summary

Use $(...) notation instead of legacy backticks

Double quote to prevent globbing and word splitting

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Selecting a random one of theses reports...
Could you create parent / child relationships between all these requests? It will make it easier to work with and integrate if you do. Thanks!

In D57871#1327028, @imp wrote:

Selecting a random one of theses reports...
Could you create parent / child relationships between all these requests? It will make it easier to work with and integrate if you do. Thanks!

Will do, but just to clarify the "why". As a new contributor I thought (perhaps wrongly ?) that the reviewer community would prefer if I kept my individual differential minimal so they were easy for you to review and reason over.

But so I know for the future, would you prefer me to create one differential that covers multiple files e.g. in this case, I could have, for example, created "shell script modernization/best practice" and lumped all the differentials in there, since they are effectively all very similar (double-quoting etc.). Or do you prefer the parent/child linking ?

And if you prefer the parent/child, e.g in this instance where there is no clear "parent", do I just pick one at random ?