Use $(...) notation instead of legacy backticks
Double quote to prevent globbing and word splitting
Differential D57871
sys/tools/fdt/make_dtb.sh: small fixes Authored by thebugfixers_pm.me on Fri, Jun 26, 10:32 AM. Tags None Referenced Files
Subscribers
Details
Use $(...) notation instead of legacy backticks Double quote to prevent globbing and word splitting
Diff Detail
Event TimelineComment Actions Selecting a random one of theses reports... Comment Actions Will do, but just to clarify the "why". As a new contributor I thought (perhaps wrongly ?) that the reviewer community would prefer if I kept my individual differential minimal so they were easy for you to review and reason over. But so I know for the future, would you prefer me to create one differential that covers multiple files e.g. in this case, I could have, for example, created "shell script modernization/best practice" and lumped all the differentials in there, since they are effectively all very similar (double-quoting etc.). Or do you prefer the parent/child linking ? And if you prefer the parent/child, e.g in this instance where there is no clear "parent", do I just pick one at random ? |