Tidy up the unmapped I/O code in qphysio.
ClosedPublic
Actions

Authored by jhb on Mar 30 2016, 10:08 PM.

Tags

None

Referenced Files

	F157560730: D5787.diff
	Fri, May 22, 8:28 PM

	Unknown Object (File)
	Sun, May 17, 8:18 AM

	Unknown Object (File)
	Sun, May 17, 8:12 AM

	Unknown Object (File)
	Wed, May 6, 12:59 PM

	Unknown Object (File)
	Mon, Apr 27, 10:03 AM

	Unknown Object (File)
	Fri, Apr 24, 12:51 AM

	Unknown Object (File)
	Apr 22 2026, 12:33 PM

	Unknown Object (File)
	Apr 21 2026, 12:19 PM

View All 58 Files

Subscribers

imp

Details

Reviewers

kib

Summary

Tidy up the unmapped I/O code in qphysio.

Move some blocks around to reduce the number of 'if (unmap)' checks.
Use 'pbuf == NULL' instead of 'unmap'.
Use nitems.
Pull an assignment out of an if expression.

Test Plan

Ran the aio tests, in particular the aio_md_test which exercise the md path.
Ran the 'fio' benchmark tool against a raw disk partition (a user reported a regression in the physio path using this tool with the original AIO rework patches)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3082
Build 3114: arc lint + arc unit

Event Timeline

jhb updated this revision to Diff 14753.Mar 30 2016, 10:08 PM

jhb retitled this revision from to Tidy up the unmapped I/O code in qphysio..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: kib.

Herald added a subscriber: imp. · View Herald TranscriptMar 30 2016, 10:08 PM

kib accepted this revision.Mar 31 2016, 5:32 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2016, 5:32 AM

Committed in rS297464.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_aio.c

40 lines

Diff 14753

View Options

Tidy up the unmapped I/O code in qphysio.ClosedPublicActions