Tidy up the unmapped I/O code in qphysio.
ClosedPublic
Actions

Authored by jhb on Mar 30 2016, 10:08 PM.

Tags

None

Referenced Files

	F171610538: D5787.id14753.diff
	Sat, Sep 12, 3:49 AM

	F171610183: D5787.diff
	Sat, Sep 12, 3:45 AM

	Unknown Object (File)
	Thu, Sep 10, 12:53 PM

	Unknown Object (File)
	Wed, Sep 9, 1:14 PM

	Unknown Object (File)
	Tue, Sep 8, 1:08 PM

	Unknown Object (File)
	Fri, Sep 4, 11:00 PM

	Unknown Object (File)
	Fri, Sep 4, 1:03 AM

	Unknown Object (File)
	Thu, Sep 3, 10:31 PM

View All 84 Files

Subscribers

imp

Details

Reviewers

kib

Summary

Tidy up the unmapped I/O code in qphysio.

Move some blocks around to reduce the number of 'if (unmap)' checks.
Use 'pbuf == NULL' instead of 'unmap'.
Use nitems.
Pull an assignment out of an if expression.

Test Plan

Ran the aio tests, in particular the aio_md_test which exercise the md path.
Ran the 'fio' benchmark tool against a raw disk partition (a user reported a regression in the physio path using this tool with the original AIO rework patches)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3082
Build 3114: arc lint + arc unit

Event Timeline

jhb updated this revision to Diff 14753.Mar 30 2016, 10:08 PM

jhb retitled this revision from to Tidy up the unmapped I/O code in qphysio..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: kib.

Herald added a subscriber: imp. · View Herald TranscriptMar 30 2016, 10:08 PM

kib accepted this revision.Mar 31 2016, 5:32 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2016, 5:32 AM

Committed in rS297464.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_aio.c

40 lines

Diff 14753

View Options

Tidy up the unmapped I/O code in qphysio.ClosedPublicActions