zfskeys - only prompt if zfskeys and zfskeys_prompt are enabled
ClosedPublic
Actions

Authored by ambrisko on Mon, Jun 22, 6:55 PM.

Tags

None

Referenced Files

	F162738590: D57750.id180317.diff
	Thu, Jul 16, 8:55 AM

	F162712060: D57750.diff
	Thu, Jul 16, 1:38 AM

	Unknown Object (File)
	Wed, Jul 15, 1:56 PM

	Unknown Object (File)
	Wed, Jul 15, 9:34 AM

	Unknown Object (File)
	Wed, Jul 15, 8:38 AM

	Unknown Object (File)
	Wed, Jul 15, 8:03 AM

	Unknown Object (File)
	Wed, Jul 15, 7:27 AM

	Unknown Object (File)
	Wed, Jul 15, 7:27 AM

View All 21 Files

Subscribers

imp

Details

Reviewers

kevans

Commits

rG276a3dacdb60: zfskeys - only prompt if zfskeys and zfskeys_prompt are enabled

Summary

By default don't block booting with a prompt if a zpool needs a keyboard
password to unlock it. To enable prompting for keyboard password during
boot require:

zfskeys_enable="YES"
zfskeys_prompt_enable="YES"

to both be enabled. This returns to POLA of prior behaviour.

PR: 296130

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ambrisko created this revision.Mon, Jun 22, 6:55 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 22, 6:55 PM

ambrisko requested review of this revision.Mon, Jun 22, 6:55 PM

Harbormaster completed remote builds in B74110: Diff 180317.Mon, Jun 22, 6:55 PM

ambrisko added a reviewer: kevans.Mon, Jun 22, 6:58 PM

Thanks!

This revision is now accepted and ready to land.Mon, Jun 22, 7:02 PM

Closed by commit rG276a3dacdb60: zfskeys - only prompt if zfskeys and zfskeys_prompt are enabled (authored by ambrisko). · Explain WhyTue, Jun 23, 3:14 PM

This revision was automatically updated to reflect the committed changes.

ambrisko added a commit: rG276a3dacdb60: zfskeys - only prompt if zfskeys and zfskeys_prompt are enabled.

Revision Contents
Changeset List

Path

Size

libexec/

rc/

rc.conf

1 line

rc.d/

zfskeys

16 lines

Diff 180382

View Options

libexec/rc/rc.conf